aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGregory Maxwell <greg@xiph.org>2017-06-16 00:46:16 +0000
committerGregory Maxwell <greg@xiph.org>2017-06-16 00:46:16 +0000
commit18873373bde38a026f154c5878fedac6c2a04446 (patch)
treeec9a4ec61a5649483ef6d8b6de4c7ba01e78f3aa
parentc2ab38bdd57a16e6c708dcc633d9162331c9d311 (diff)
Add a comment explaining the use of MAX_BLOCK_BASE_SIZE.
-rw-r--r--src/consensus/consensus.h8
1 files changed, 7 insertions, 1 deletions
diff --git a/src/consensus/consensus.h b/src/consensus/consensus.h
index 351911a3a4..58b2ed4b3e 100644
--- a/src/consensus/consensus.h
+++ b/src/consensus/consensus.h
@@ -12,7 +12,13 @@
static const unsigned int MAX_BLOCK_SERIALIZED_SIZE = 4000000;
/** The maximum allowed weight for a block, see BIP 141 (network rule) */
static const unsigned int MAX_BLOCK_WEIGHT = 4000000;
-/** The maximum allowed size for a block excluding witness data, in bytes (network rule) */
+/**
+ * The maximum allowed size for a block excluding witness data, in bytes (network rule).
+ * This parameter is largely superfluous because it is directly implied by the above block
+ * weight limit, even when BIP 141 is not active. It continues to exist for use in
+ * various early tests that run before the witness data has been checked.
+ * All tests related to it could be removed without breaking consensus compatibility.
+ */
static const unsigned int MAX_BLOCK_BASE_SIZE = 1000000;
/** The maximum allowed number of signature check operations in a block (network rule) */
static const int64_t MAX_BLOCK_SIGOPS_COST = 80000;