diff options
| author | Jim Posen <jim.posen@gmail.com> | 2018-08-27 12:28:35 -0700 |
|---|---|---|
| committer | Jim Posen <jim.posen@gmail.com> | 2018-08-27 17:03:24 -0700 |
| commit | ed12d5df1ba52b5ef3dd3799de26bb5e1d3fc654 (patch) | |
| tree | 947882744b34f59d1668b3d4636641c4b9daaed3 | |
| parent | 0df9b0aed23127acd12d9ed6a008c12be47b1cd9 (diff) | |
index: Fix for indexers skipping genesis block.
| -rw-r--r-- | src/index/base.cpp | 6 | ||||
| -rw-r--r-- | src/index/txindex.cpp | 3 | ||||
| -rw-r--r-- | src/test/txindex_tests.cpp | 7 |
3 files changed, 15 insertions, 1 deletions
diff --git a/src/index/base.cpp b/src/index/base.cpp index 788f7adccd..3cf2a89a2d 100644 --- a/src/index/base.cpp +++ b/src/index/base.cpp @@ -60,7 +60,11 @@ bool BaseIndex::Init() } LOCK(cs_main); - m_best_block_index = FindForkInGlobalIndex(chainActive, locator); + if (locator.IsNull()) { + m_best_block_index = nullptr; + } else { + m_best_block_index = FindForkInGlobalIndex(chainActive, locator); + } m_synced = m_best_block_index.load() == chainActive.Tip(); return true; } diff --git a/src/index/txindex.cpp b/src/index/txindex.cpp index c85030e18e..224004ce1c 100644 --- a/src/index/txindex.cpp +++ b/src/index/txindex.cpp @@ -245,6 +245,9 @@ bool TxIndex::Init() bool TxIndex::WriteBlock(const CBlock& block, const CBlockIndex* pindex) { + // Exclude genesis block transaction because outputs are not spendable. + if (pindex->nHeight == 0) return true; + CDiskTxPos pos(pindex->GetBlockPos(), GetSizeOfCompactSize(block.vtx.size())); std::vector<std::pair<uint256, CDiskTxPos>> vPos; vPos.reserve(block.vtx.size()); diff --git a/src/test/txindex_tests.cpp b/src/test/txindex_tests.cpp index 2a160b9988..b5aa8160ed 100644 --- a/src/test/txindex_tests.cpp +++ b/src/test/txindex_tests.cpp @@ -2,6 +2,7 @@ // Distributed under the MIT software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. +#include <chainparams.h> #include <index/txindex.h> #include <script/standard.h> #include <test/test_bitcoin.h> @@ -38,6 +39,12 @@ BOOST_FIXTURE_TEST_CASE(txindex_initial_sync, TestChain100Setup) MilliSleep(100); } + // Check that txindex excludes genesis block transactions. + const CBlock& genesis_block = Params().GenesisBlock(); + for (const auto& txn : genesis_block.vtx) { + BOOST_CHECK(!txindex.FindTx(txn->GetHash(), block_hash, tx_disk)); + } + // Check that txindex has all txs that were in the chain before it started. for (const auto& txn : m_coinbase_txns) { if (!txindex.FindTx(txn->GetHash(), block_hash, tx_disk)) { |