diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-04-07 02:21:50 +0800 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-04-07 02:21:53 +0800 |
| commit | 54d5ba3d9cb45d8417ecca0f09c68d865d0c423c (patch) | |
| tree | 24f1b994ef1343ac24e8a1f0c044f3d5426e981a | |
| parent | c0b389b33516fb3eaaad7c30bd11dba768882a7e (diff) | |
| parent | b224b4e7bd8c52bb70d933c1bc524c0fe87ac0c1 (diff) | |
Merge #18540: test: wallet_bumpfee assertion fixup
b224b4e7bd8c52bb70d933c1bc524c0fe87ac0c1 test: wallet_bumpfee assertion fixup (Jon Atack)
Pull request description:
Follow-up to #18516 to fix up an assertion as per suggested change in https://github.com/bitcoin/bitcoin/pull/18516#discussion_r404191587.
ACKs for top commit:
jnewbery:
ACK b224b4e7bd8c52bb70d933c1bc524c0fe87ac0c1
Tree-SHA512: 4973bba73a67c1ffaf460921b3d454e9d66a40a67f73b7df742e24a0e389adba3946a3958a729391ee6bfa4ef844be759ebf71d14d788434c248e48a2bbe5bde
| -rwxr-xr-x | test/functional/wallet_bumpfee.py | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/test/functional/wallet_bumpfee.py b/test/functional/wallet_bumpfee.py index 2e6a3e0ce4..0b3dea94d5 100755 --- a/test/functional/wallet_bumpfee.py +++ b/test/functional/wallet_bumpfee.py @@ -258,8 +258,7 @@ def test_dust_to_fee(self, rbf_node, dest_address): # in the witness is divided by 4 for the vsize, so this variance can take the weight across a 4-byte # boundary. Thus expected transaction size (p2wpkh, 1 input, 2 outputs) is 140-141 vbytes, usually 141. if not 140 <= fulltx["vsize"] <= 141: - print("Error: Invalid tx vsize of {} (140-141 expected), full tx: {}".format(fulltx["vsize"], fulltx)) - raise AssertionError + raise AssertionError("Invalid tx vsize of {} (140-141 expected), full tx: {}".format(fulltx["vsize"], fulltx)) # Bump with fee_rate of 0.00350250 BTC per 1000 vbytes to create dust. # Expected fee is 141 vbytes * fee_rate 0.00350250 BTC / 1000 vbytes = 0.00049385 BTC. # or occasionally 140 vbytes * fee_rate 0.00350250 BTC / 1000 vbytes = 0.00049035 BTC. |