diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2019-05-09 18:04:03 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2019-05-09 18:04:07 +0200 |
| commit | aebe990dfeb41bcd022a44db28fbedd435d2f433 (patch) | |
| tree | dfad477d67c9ee902e4e2bb757af06ae1b3a3730 | |
| parent | a65fd92f7b8ecb6a2d38aaac7660df01d2441723 (diff) | |
| parent | f4a230b627bf9ff53e14719609849ee05b022480 (diff) | |
Merge #15794: docs: Clarify PR guidelines w/re documentation
f4a230b627bf9ff53e14719609849ee05b022480 docs: Clarify PR guidelines w/re documentation (Carl Dong)
Pull request description:
PRs should change documentation accordingly when the behaviour of code changes.
ACKs for commit f4a230:
practicalswift:
ACK f4a230b627bf9ff53e14719609849ee05b022480
fanquake:
utACK f4a230b
Tree-SHA512: 6d9d65d7f0f9bc8f324ee16f03169df28fb512c58bb71093128cf16797b25533cdc992bc8757034a99d6fa6423a3129ca7cf2ab2da857535f409a683486fd4ab
| -rw-r--r-- | CONTRIBUTING.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 007ebd7ccf..5df99adba8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -220,6 +220,7 @@ In general, all pull requests must: - Not break the existing test suite; - Where bugs are fixed, where possible, there should be unit tests demonstrating the bug and also proving the fix. This helps prevent regression. + - Change relevant comments and documentation when behaviour of code changes. Patches that change Bitcoin consensus rules are considerably more involved than normal because they affect the entire ecosystem and so must be preceded by |