diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-10-02 08:38:10 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-10-02 08:38:12 +0200 |
| commit | a6a993a888f578fcb8d6ff60ce0265fad55dafcb (patch) | |
| tree | 9edbbe794dc8db4d86baaf37d3eed2844ab0a785 | |
| parent | 69a73803dfb2f65919660902d126487906a31770 (diff) | |
| parent | 82b70f15c72adc777bddc7ae7b1e359fb5daf1f1 (diff) | |
| download | bitcoin-a6a993a888f578fcb8d6ff60ce0265fad55dafcb.tar.xz | |
Merge #20060: refactor: fix -Wbraced-scalar-init warning in validation tests
82b70f15c72adc777bddc7ae7b1e359fb5daf1f1 refactor: fix -Wbraced-scalar-init warning in validation tests (fanquake)
Pull request description:
Introduced in #20004 (fa29b5ae666bbb4c19188f0dcf8a1ba738aac624).
```
test/validation_tests.cpp:68:88: warning: braces around scalar initializer [-Wbraced-scalar-init]
BOOST_CHECK(signet_params->GetConsensus().signet_challenge == std::vector<uint8_t>{{OP_TRUE}});
^~~~~~~~~
/usr/local/include/boost/test/tools/old/interface.hpp:83:6: note: expanded from macro 'BOOST_CHECK'
(P), BOOST_TEST_STRINGIZE( P ), CHECK, CHECK_PRED, _ )
^
/usr/local/include/boost/test/tools/old/interface.hpp:68:61: note: expanded from macro 'BOOST_TEST_TOOL_IMPL'
BOOST_JOIN( BOOST_TEST_TOOL_PASS_PRED, frwd_type )( P, ARGS ), \
^
/usr/local/include/boost/test/tools/old/interface.hpp:51:47: note: expanded from macro 'BOOST_TEST_TOOL_PASS_PRED2'
^
1 warning generated.
```
ACKs for top commit:
practicalswift:
ACK 82b70f15c72adc777bddc7ae7b1e359fb5daf1f1
MarcoFalke:
ACK 82b70f15c72adc777bddc7ae7b1e359fb5daf1f1
Tree-SHA512: ae14acd52e2a0d370a6ee7321f257190c6a44094eb3fa5a6bd85b6bb2b4002e7784589cb34dcf78545238c33cbea38113061b2a46e092f1119731e70932fa469
| -rw-r--r-- | src/test/validation_tests.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test/validation_tests.cpp b/src/test/validation_tests.cpp index a9ece50136..7fea31938a 100644 --- a/src/test/validation_tests.cpp +++ b/src/test/validation_tests.cpp @@ -65,7 +65,7 @@ BOOST_AUTO_TEST_CASE(signet_parse_tests) signet_argsman.ForceSetArg("-signetchallenge", "51"); // set challenge to OP_TRUE const auto signet_params = CreateChainParams(signet_argsman, CBaseChainParams::SIGNET); CBlock block; - BOOST_CHECK(signet_params->GetConsensus().signet_challenge == std::vector<uint8_t>{{OP_TRUE}}); + BOOST_CHECK(signet_params->GetConsensus().signet_challenge == std::vector<uint8_t>{OP_TRUE}); CScript challenge{OP_TRUE}; // empty block is invalid |