diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-11-01 14:27:50 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-11-01 14:28:16 +0100 |
| commit | 08a57d51e90c232421681c9e6fe037ea4b3ed079 (patch) | |
| tree | 1ce40a7d6693b00e6a2b06ee584347618c1532a1 | |
| parent | d38a5092f17ff4c357c5cfd4e6caee33cbafcbf0 (diff) | |
| parent | cf2f4306fe26305b24bba8833af845ada3a42ec8 (diff) | |
Merge #14593: gui: explicitly disable "Dark Mode" appearance on macOS
cf2f4306fe26305b24bba8833af845ada3a42ec8 gui: explicitly disable "Dark Mode" appearance on macOS (fanquake)
Pull request description:
Bitcoin Core's gui is pretty broken for a someone using macOS in "Dark Mode"; the biggest issue being lots of white text on a white background, leaving most inputs, the rpc console etc unusable.
This is likely something we'll have to wait for Qt to fix/support, so it's probably easiest to just disable for now, rather than provide a broken UI; see screenshots below. This issue might not have come up much yet, given the issues with the 0.17.0 dmg.
Apple documentation on "Opting out of Dark Mode" is [here](https://developer.apple.com/documentation/appkit/nsappearancecustomization/choosing_a_specific_appearance_for_your_app).
> If you need extra time to work on your app's Dark Mode support, you can temporarily opt out by including the NSRequiresAquaSystemAppearance key (with a value of true) in your app’s Info.plist file. Setting this key to true causes the system to ignore the user's preference and always apply a light appearance to your app.
Related upstream tickets:
* [Qt Applications are not usable under macOS Mojave with dark theme](https://bugreports.qt.io/browse/QTBUG-68850)
* [macOS 10.14 Mojave Support](https://bugreports.qt.io/browse/QTBUG-68891)
Screenshots:
Tree-SHA512: 01f6f6b1fed0f20937b433adef38ff55ccacce8b4405dd6be67356ee9a470a56b8e511cc79909a39c3091a852f444284e49a8773cf6c037a29669804185ca92d
| -rw-r--r-- | share/qt/Info.plist.in | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/share/qt/Info.plist.in b/share/qt/Info.plist.in index 17b4ee47de..0c0335a1e8 100644 --- a/share/qt/Info.plist.in +++ b/share/qt/Info.plist.in @@ -99,6 +99,9 @@ <key>LSAppNapIsDisabled</key> <string>True</string> + + <key>NSRequiresAquaSystemAppearance</key> + <string>True</string> <key>LSApplicationCategoryType</key> <string>public.app-category.finance</string> |