diff options
| author | Ben Woosley <ben.woosley@gmail.com> | 2019-01-24 16:57:41 -0800 |
|---|---|---|
| committer | Ben Woosley <ben.woosley@gmail.com> | 2019-01-24 16:57:41 -0800 |
| commit | f618c58b75ba365ef851089ba31017273d52f777 (patch) | |
| tree | 178347032b43c4d54c1294fee0106ac9783ddf53 | |
| parent | 72bd4ab867e3be0d8410403d9641c08288d343e3 (diff) | |
Docs: Update python docs to reflect that wildcard imports are disallowed
| -rw-r--r-- | test/functional/README.md | 2 | ||||
| -rwxr-xr-x | test/functional/example_test.py | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/test/functional/README.md b/test/functional/README.md index bce0d5db2e..628c77eb11 100644 --- a/test/functional/README.md +++ b/test/functional/README.md @@ -26,7 +26,7 @@ don't have test cases for. The Travis linter also checks this, but [possibly not in all cases](https://github.com/bitcoin/bitcoin/pull/14884#discussion_r239585126). - See [the python lint script](/test/lint/lint-python.sh) that checks for violations that could lead to bugs and issues in the test code. -- Avoid wildcard imports where possible +- Avoid wildcard imports - Use a module-level docstring to describe what the test is testing, and how it is testing it. - When subclassing the BitcoinTestFramwork, place overrides for the diff --git a/test/functional/example_test.py b/test/functional/example_test.py index be3544ee74..f367e4fca8 100755 --- a/test/functional/example_test.py +++ b/test/functional/example_test.py @@ -13,7 +13,7 @@ is testing and *how* it's being tested # libraries then local imports). from collections import defaultdict -# Avoid wildcard * imports if possible +# Avoid wildcard * imports from test_framework.blocktools import (create_block, create_coinbase) from test_framework.messages import CInv from test_framework.mininode import ( |