Merge #15081: Doc: Update release notes for master through to 2019-01-01

f3d7d75e4e80bcd2c6058babb732c9c6cc7522c6 Release notes: integrate detached release notes (David A. Harding)
97fbe6794037268667d92c788671fdea60c9b630 Release notes: update notes through fb52d0684 (David A. Harding)

Pull request description:

  This adds release notes for the changes listed by `git log 11e1ac3...fb52d0684 --merges`, picking up where #14688 left off in my attempt to update the release notes every month or so (reducing the amount of work that needs to be done near release time).  I've excluded changes backported to the 0.17 branch (whether they've been released yet or not).

Tree-SHA512: 7d08fb0e1c08d038a4ca46e6c11da2d3dc093e3827796f47cb6177d2bd5303be583fb05e1eb04c0bb12ecb63a879a6075c9a32cc03e4841ffadee7b9c480eefc

5 files changed, 91 insertions, 71 deletions

diff --git a/doc/release-notes-14060.md b/doc/release-notes-14060.md
deleted file mode 100644
index 2cc5ab49fb..0000000000
--- a/doc/release-notes-14060.md
+++ /dev/null
@@ -1,21 +0,0 @@
-Configuration
--------------
-
-The outbound message high water mark of the ZMQ PUB sockets are now
-configurable via the options:
-
-`-zmqpubhashtxhwm=n`
-
-`-zmqpubhashblockhwm=n`
-
-`-zmqpubrawblockhwm=n`
-
-`-zmqpubrawtxhwm=n`
-
-Each high water mark value must be an integer greater than or equal to 0.
-The high water mark limits the maximum number of messages that ZMQ will
-queue in memory for any single subscriber. A value of 0 means no limit.
-When not specified, the default value continues to be 1000.
-When a ZMQ PUB socket reaches its high water mark for a subscriber, then
-additional messages to the subscriber are dropped until the number of
-queued messages again falls below the high water mark value.
diff --git a/doc/release-notes-14477.md b/doc/release-notes-14477.md
deleted file mode 100644
index bb8c0a623e..0000000000
--- a/doc/release-notes-14477.md
+++ /dev/null
@@ -1,5 +0,0 @@
-Miscellaneous RPC changes
-------------
-
-- `getaddressinfo` now reports `solvable`, a boolean indicating whether all information necessary for signing is present in the wallet (ignoring private keys).
-- `getaddressinfo`, `listunspent`, and `scantxoutset` have a new output field `desc`, an output descriptor that encapsulates all signing information and key paths for the address (only available when `solvable` is true for `getaddressinfo` and `listunspent`).
diff --git a/doc/release-notes-14565.md b/doc/release-notes-14565.md
deleted file mode 100644
index 38d76fee46..0000000000
--- a/doc/release-notes-14565.md
+++ /dev/null
@@ -1,5 +0,0 @@
-Low-level RPC changes
----------------------
-
-The `importmulti` RPC will now contain a new per-request `warnings` field with strings
-that explain when fields are being ignored or inconsistant, if any.
diff --git a/doc/release-notes-pr13381.md b/doc/release-notes-pr13381.md
deleted file mode 100644
index 75faad9906..0000000000
--- a/doc/release-notes-pr13381.md
+++ /dev/null
@@ -1,29 +0,0 @@
-RPC importprivkey: new label behavior
--------------------------------------
-
-Previously, `importprivkey` automatically added the default empty label
-("") to all addresses associated with the imported private key.  Now it
-defaults to using any existing label for those addresses.  For example:
-
-- Old behavior: you import a watch-only address with the label "cold
-  wallet".  Later, you import the corresponding private key using the
-  default settings.  The address's label is changed from "cold wallet"
-  to "".
-
-- New behavior: you import a watch-only address with the label "cold
-  wallet".  Later, you import the corresponding private key using the
-  default settings.  The address's label remains "cold wallet".
-
-In both the previous and current case, if you directly specify a label
-during the import, that label will override whatever previous label the
-addresses may have had.  Also in both cases, if none of the addresses
-previously had a label, they will still receive the default empty label
-("").  Examples:
-
-- You import a watch-only address with the label "temporary".  Later you
-  import the corresponding private key with the label "final".  The
-  address's label will be changed to "final".
-
-- You use the default settings to import a private key for an address that
-  was not previously in the wallet.  Its addresses will receive the default
-  empty label ("").
diff --git a/doc/release-notes.md b/doc/release-notes.md
index 6b4bb478e9..53b5a2119f 100644
--- a/doc/release-notes.md
+++ b/doc/release-notes.md
@@ -72,16 +72,44 @@ Mining
 - Calls to `getblocktemplate` will fail if the segwit rule is not specified.
   Calling `getblocktemplate` without segwit specified is almost certainly
   a misconfiguration since doing so results in lower rewards for the miner.
-
-Command line option changes
----------------------------
-
-The `-enablebip61` command line option (introduced in Bitcoin Core 0.17.0) is
-used to toggle sending of BIP 61 reject messages. Reject messages have no use
-case on the P2P network and are only logged for debugging by most network
-nodes. The option will now by default be off for improved privacy and security
-as well as reduced upload usage. The option can explicitly be turned on for
-local-network debugging purposes.
+  Failed calls will produce an error message describing how to enable the
+  segwit rule.
+
+Configuration option changes
+----------------------------
+
+- A warning is printed if an unrecognized section name is used in the
+  configuration file.  Recognized sections are `[test]`, `[main]`, and
+  `[regtest]`.
+
+- Four new options are available for configuring the maximum number of
+  messages that ZMQ will queue in memory (the "high water mark") before
+  dropping additional messages.  The default value is 1,000, the same as
+  was used for previous releases.  See the [ZMQ
+  documentation](https://github.com/bitcoin/bitcoin/blob/master/doc/zmq.md#usage)
+  for details.
+
+- The `enablebip61` option (introduced in Bitcoin Core 0.17.0) is
+  used to toggle sending of BIP 61 reject messages. Reject messages have no use
+  case on the P2P network and are only logged for debugging by most network
+  nodes. The option will now by default be off for improved privacy and security
+  as well as reduced upload usage. The option can explicitly be turned on for
+  local-network debugging purposes.
+
+- The `rpcallowip` option can no longer be used to automatically listen
+  on all network interfaces.  Instead, the `rpcbind` parameter must also
+  be used to specify the IP addresses to listen on.  Listening for RPC
+  commands over a public network connection is insecure and should be
+  disabled, so a warning is now printed if a user selects such a
+  configuration.  If you need to expose RPC in order to use a tool
+  like Docker, ensure you only bind RPC to your localhost, e.g. `docker
+  run [...] -p 127.0.0.1:8332:8332` (this is an extra `:8332` over the
+  normal Docker port specification).
+
+- The `rpcpassword` option now causes a startup error if the password
+  set in the configuration file contains a hash character (#), as it's
+  ambiguous whether the hash character is meant for the password or as a
+  comment.
 
 Documentation
 -------------
@@ -168,7 +196,7 @@ Updated RPCs
 Note: some low-level RPC changes mainly useful for testing are described
 in the Low-level Changes section below.
 
-- The `getpeerinfo` RPC now returns an additional "minfeefilter" field
+- The `getpeerinfo` RPC now returns an additional `minfeefilter` field
   set to the peer's BIP133 fee filter.  You can use this to detect that
   you have peers that are willing to accept transactions below the
   default minimum relay fee.
@@ -190,8 +218,50 @@ in the Low-level Changes section below.
   P2SH-P2WPKH, and P2SH-P2WSH. Requests for P2WSH and P2SH-P2WSH accept
   an additional `witnessscript` parameter.
 
+- The `importmulti` RPC now returns an additional `warnings` field for
+  each request with an array of strings explaining when fields are being
+  ignored or are inconsistent, if there are any.
+
+- The `getaddressinfo` RPC now returns an additional `solvable` boolean
+  field when Bitcoin Core knows enough about the address's scriptPubKey,
+  optional redeemScript, and optional witnessScript in order for the
+  wallet to be able to generate an unsigned input spending funds sent to
+  that address.
+
+- The `getaddressinfo`, `listunspent`, and `scantxoutset` RPCs now
+  return an additional `desc` field that contains an output descriptor
+  containing all key paths and signing information for the address
+  (except for the private key).  The `desc` field is only returned for
+  `getaddressinfo` and `listunspent` when the address is solvable.
+
+- The `importprivkey` RPC will preserve previously-set labels for
+  addresses or public keys corresponding to the private key being
+  imported.  For example, if you imported a watch-only address with the
+  label "cold wallet" in earlier releases of Bitcoin Core, subsequently
+  importing the private key would default to resetting the address's
+  label to the default empty-string label ("").  In this release, the
+  previous label of "cold wallet" will be retained.  If you optionally
+  specify any label besides the default when calling `importprivkey`,
+  the new label will be applied to the address.
+
 - See the [Mining](#mining) section for changes to `getblocktemplate`.
 
+Graphical User Interface (GUI)
+------------------------------
+
+- A new Window menu is added alongside the existing File, Settings, and
+  Help menus.  Several items from the other menus that opened new
+  windows have been moved to this new Window menu.
+
+- In the Send tab, the checkbox for "pay only the required fee"
+  has been removed.  Instead, the user can simply decrease the value in
+  the Custom Feerate field all the way down to the node's configured
+  minimum relay fee.
+
+- In the Overview tab, the watch-only balance will be the only
+  balance shown if the wallet was created using the `createwallet` RPC
+  and the `disable_private_keys` parameter was set to true.
+
 Low-level changes
 =================
 
@@ -216,6 +286,16 @@ Configuration
   deterministic wallets. This release makes specifying `-usehd` an
   invalid configuration option.
 
+Changes for particular platforms
+--------------------------------
+
+- On macOS, Bitcoin Core now opts out of application CPU throttling
+  ("app nap") during initial blockchain download, when catching up from
+  over 100 blocks behind the current chain tip, or when reindexing chain
+  data.  This helps prevent these operations from taking an excessively
+  long time because the operating system is attempting to conserve
+  power.
+
 Credits
 =======