diff options
author | Russell Yanofsky <russ@yanofsky.org> | 2020-01-10 14:55:10 -0500 |
---|---|---|
committer | Russell Yanofsky <russ@yanofsky.org> | 2020-01-10 14:55:10 -0500 |
commit | 8313fa8e8112e429e104b7e7fd48e5e6e359b82e (patch) | |
tree | b2927e1cfe224195bfcd39f97c673482de353597 | |
parent | e7f84503571c171a7e6728cd2d77dd4103bd7a6f (diff) | |
download | bitcoin-8313fa8e8112e429e104b7e7fd48e5e6e359b82e.tar.xz |
gui: Set CConnman byte counters earlier to avoid uninitialized reads
Initialize CConnman byte counters during construction, so GetTotalBytesRecv()
and GetTotalBytesSent() methods don't return garbage before Start() is called.
Change shouldn't have any effect outside of the GUI. It just fixes a race
condition during a qt test that was observed on travis:
https://travis-ci.org/bitcoin/bitcoin/jobs/634989685
-rw-r--r-- | src/net.h | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -386,8 +386,8 @@ private: // Network usage totals CCriticalSection cs_totalBytesRecv; CCriticalSection cs_totalBytesSent; - uint64_t nTotalBytesRecv GUARDED_BY(cs_totalBytesRecv); - uint64_t nTotalBytesSent GUARDED_BY(cs_totalBytesSent); + uint64_t nTotalBytesRecv GUARDED_BY(cs_totalBytesRecv) {0}; + uint64_t nTotalBytesSent GUARDED_BY(cs_totalBytesSent) {0}; // outbound limit & stats uint64_t nMaxOutboundTotalBytesSentInCycle GUARDED_BY(cs_totalBytesSent); |