diff options
| author | fanquake <fanquake@gmail.com> | 2019-06-25 13:33:36 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2019-06-25 14:36:51 +0800 |
| commit | bc948d4cfd6da2effa8c2ae619e11e83207c6fbc (patch) | |
| tree | 02cdfb9537e33eb03564d64e15669b538f8470a0 | |
| parent | 21bd6eb782ca9a06d40c6876b11e7db6308275fb (diff) | |
| parent | 30ea931dee8e4533c4b8efe00693aebb6fbd78fc (diff) | |
| download | bitcoin-bc948d4cfd6da2effa8c2ae619e11e83207c6fbc.tar.xz | |
Merge #16183: depends: xtrans: Configure flags cleanup.
30ea931dee8e4533c4b8efe00693aebb6fbd78fc depends: xtrans: Configure flags cleanup. (Carl Dong)
Pull request description:
```
xtrans does not understand the --with-pic and --disable-shared flags we
pass it because it is not a library. Instead, we should pass it flags
that disable features/packages we're not using so they don't get a
chance to sneak in.
```
Here's a comparison of stdout and stderr of `make -j(nproc) V=1 xtrans_built` before and after this PR: https://gist.github.com/dongcarl/4ebf6fe9985ebc1508190f75932e4237
ACKs for top commit:
fanquake:
ACK 30ea931dee8e4533c4b8efe00693aebb6fbd78fc
Tree-SHA512: 49e060dffbae8c148c1164b493d03e7db4f260e7746d94c783377185c665e16fb6638827473709ed543eb266cc293d2313f61ade05ee8af4edb0bfbda0d1f785
| -rw-r--r-- | depends/packages/xtrans.mk | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/depends/packages/xtrans.mk b/depends/packages/xtrans.mk index 1993ff8344..6201d1d270 100644 --- a/depends/packages/xtrans.mk +++ b/depends/packages/xtrans.mk @@ -6,7 +6,7 @@ $(package)_sha256_hash=054d4ee3efd52508c753e9f7bc655ef185a29bd2850dd9e2fc2ccc335 $(package)_dependencies= define $(package)_set_vars -$(package)_config_opts_linux=--with-pic --disable-shared + $(package)_config_opts_linux=--disable-docs --without-xmlto --without-fop --without-xsltproc endef define $(package)_preprocess_cmds |