diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2019-09-30 09:48:10 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2019-09-30 09:48:36 +0200 |
| commit | 942e275018e17ddf0169f02dced0b97b854e87c1 (patch) | |
| tree | 351f9277957b94bcf03e3fdf51944ac5012a9c19 | |
| parent | 6b9405e3191206f1cda626423aab6a453980ab05 (diff) | |
| parent | 203a67d21f566634165531a7a75c3f8c9f9c9d6a (diff) | |
| download | bitcoin-942e275018e17ddf0169f02dced0b97b854e87c1.tar.xz | |
Merge #16962: doc: Put PR template in comments
203a67d21f566634165531a7a75c3f8c9f9c9d6a doc: Put PR template in comments (Wladimir J. van der Laan)
Pull request description:
This prevents the common annoyance of the text being included into PRs
accidentally.
ACKs for top commit:
sdaftuar:
utACK 203a67d21f566634165531a7a75c3f8c9f9c9d6a
fanquake:
ACK 203a67d21f566634165531a7a75c3f8c9f9c9d6a - I make an effort to remove it whenever I see it in a PR.
Tree-SHA512: 3514d285488b7930d7f3d7f8823198d7325d8b7de57a6d8f13e559c0c23b30d58916b15782cbbdc347a375b418e9d0f7a5b99b34d26f3b957d7d5a03a3d83dfd
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 00d5478c4e..d2c3b23375 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,9 +1,14 @@ +<!-- +*** Please remove the following help text before submitting: *** + Pull requests without a rationale and clear improvement may be closed immediately. +--> +<!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience -significantly. +significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or @@ -24,8 +29,11 @@ significantly. is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. +--> +<!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. +--> |