diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2019-09-25 11:28:56 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2019-09-25 15:37:19 +0200 |
| commit | 203a67d21f566634165531a7a75c3f8c9f9c9d6a (patch) | |
| tree | d1c5d6aabf25c962816b97c59d54adf23cac08de | |
| parent | 36604b4ef568aaf131f11c2b10e8c39e7a04b464 (diff) | |
| download | bitcoin-203a67d21f566634165531a7a75c3f8c9f9c9d6a.tar.xz | |
doc: Put PR template in comments
This prevents the common annoyance of the text being included into PRs
accidentally.
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 00d5478c4e..d2c3b23375 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,9 +1,14 @@ +<!-- +*** Please remove the following help text before submitting: *** + Pull requests without a rationale and clear improvement may be closed immediately. +--> +<!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience -significantly. +significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or @@ -24,8 +29,11 @@ significantly. is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. +--> +<!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. +--> |