aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarcoFalke <falke.marco@gmail.com>2018-05-30 16:47:30 -0400
committerMarcoFalke <falke.marco@gmail.com>2018-05-30 16:48:24 -0400
commitfaac7a2db4f9f511c901cb1b4d4e7c599b92884f (patch)
tree703bf6459c488167046218964454efdb0d385bba
parent472fe8a2ce9f08f0311e4a04eef996eba19ff985 (diff)
qa: Avoid checking reject code for now
The node will often disconnect before sending a reject code. A more robust solution would be to read from the debug log.
-rwxr-xr-xtest/functional/p2p_invalid_tx.py4
1 files changed, 1 insertions, 3 deletions
diff --git a/test/functional/p2p_invalid_tx.py b/test/functional/p2p_invalid_tx.py
index 34041ca109..3fed872ccc 100755
--- a/test/functional/p2p_invalid_tx.py
+++ b/test/functional/p2p_invalid_tx.py
@@ -21,8 +21,6 @@ from test_framework.util import (
)
-REJECT_INVALID = 16
-
class InvalidTxRequestTest(BitcoinTestFramework):
def set_test_params(self):
self.num_nodes = 1
@@ -73,7 +71,7 @@ class InvalidTxRequestTest(BitcoinTestFramework):
# and we get disconnected immediately
self.log.info('Test a transaction that is rejected')
tx1 = create_transaction(block1.vtx[0], 0, b'\x64' * 35, 50 * COIN - 12000)
- node.p2p.send_txs_and_test([tx1], node, success=False, expect_disconnect=True, reject_code=REJECT_INVALID, reject_reason=b'mandatory-script-verify-flag-failed (Invalid OP_IF construction)')
+ node.p2p.send_txs_and_test([tx1], node, success=False, expect_disconnect=True)
# Make two p2p connections to provide the node with orphans
# * p2ps[0] will send valid orphan txs (one with low fee)