aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarcoFalke <falke.marco@gmail.com>2019-01-15 16:05:48 -0500
committerMarcoFalke <falke.marco@gmail.com>2019-01-15 16:05:50 -0500
commit391a27376b30492f55b398fc220ee96cf3769a32 (patch)
treeab9910304452adf0d0a0979dbe52b904eef15a9c
parentc7c84209bb0aafa9c8e79d0bf5f1d4b64f0ed303 (diff)
parent04215eb328de23151ef1e3572b7a16a9f4efa1a2 (diff)
downloadbitcoin-391a27376b30492f55b398fc220ee96cf3769a32.tar.xz
Merge #15173: [doc] explain what .python-version does
04215eb328 [doc] explain what .python-version does (Sjors Provoost) Pull request description: Documentation followup to https://github.com/bitcoin/bitcoin/pull/14884#discussion_r241444376. Tree-SHA512: 7b2b2718f998b7257273fab2e4f1d127f7af468cd26b2bf05b3dc7d6367e349e0a9c92e976a2760e83cf56feb68c37c89cb3a8d92e20be900bea3fb7f1f3d47b
-rw-r--r--test/functional/README.md4
1 files changed, 4 insertions, 0 deletions
diff --git a/test/functional/README.md b/test/functional/README.md
index d40052ac93..bce0d5db2e 100644
--- a/test/functional/README.md
+++ b/test/functional/README.md
@@ -20,6 +20,10 @@ don't have test cases for.
- Where possible, try to adhere to [PEP-8 guidelines](https://www.python.org/dev/peps/pep-0008/)
- Use a python linter like flake8 before submitting PRs to catch common style
nits (eg trailing whitespace, unused imports, etc)
+- The oldest supported Python version is specified in [doc/dependencies.md](/doc/dependencies.md).
+ Consider using [pyenv](https://github.com/pyenv/pyenv), which checks [.python-version](/.python-version),
+ to prevent accidentally introducing modern syntax from an unsupported Python version.
+ The Travis linter also checks this, but [possibly not in all cases](https://github.com/bitcoin/bitcoin/pull/14884#discussion_r239585126).
- See [the python lint script](/test/lint/lint-python.sh) that checks for violations that
could lead to bugs and issues in the test code.
- Avoid wildcard imports where possible