diff options
| author | Karl-Johan Alm <kalle.alm@gmail.com> | 2018-07-30 22:53:47 +0900 |
|---|---|---|
| committer | Karl-Johan Alm <kalle.alm@gmail.com> | 2018-07-30 23:47:46 +0900 |
| commit | db213aa47f6c9a2f3945ddd14f5912f1e8b9c9fc (patch) | |
| tree | 5f2ed32c217cbd8fede28efb7366977c11e8cab9 | |
| parent | 222e627322ce4de3292259a4868d23983f2a5394 (diff) | |
doc: add note to contributor docs about warranted PR's
| -rw-r--r-- | CONTRIBUTING.md | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3ee5a04796..3d5dc3221b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -119,6 +119,8 @@ At this stage one should expect comments and review from other contributors. You can add more commits to your pull request by committing them locally and pushing to your fork until you have satisfied all feedback. +Note: Code review is a burdensome but important part of the development process, and as such, certain types of pull requests are rejected. In general, if the **improvements** do not warrant the **review effort** required, the PR has a high chance of being rejected. It is up to the PR author to convince the reviewers that the changes warrant the review effort, and if reviewers are "Concept NAK'ing" the PR, the author may need to present arguments and/or do research backing their suggested changes. + Squashing Commits --------------------------- If your pull request is accepted for merging, you may be asked by a maintainer |