diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2018-01-05 12:38:19 -0900 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2018-01-05 12:38:22 -0900 |
| commit | fd4ca17360e6fc0c9bb76bf6b5b07c9102c12728 (patch) | |
| tree | d5bb1fccce6b782104344eeb131868c47d752850 | |
| parent | 56910285fa4a7a0f3b931e7613b9691cee9c13ff (diff) | |
| parent | 8a93543419300bd78e189429e003c8b17c1b983a (diff) | |
| download | bitcoin-fd4ca17360e6fc0c9bb76bf6b5b07c9102c12728.tar.xz | |
Merge #12092: [qt] Replaces numbered place marker %2 with %1.
8a93543419 Replaces numbered place marker %2 with %1. (251)
Pull request description:
This PR closes #12015 in which @chen610620 suggests to replace numbered place marker `%2` with `%1`.
Calling member function`QString::arg()` on a `QString` object with one arbitrary numbered place marker within the range [1,99] works, because `QString::arg()` replaces the _lowest_ numbered place marker in the `QString` object it is called on.
[QString::arg documentation:](http://doc.qt.io/qt-5/qstring.html#arg)
> Returns a copy of this string with the lowest numbered place marker replaced by string a, i.e., %1, %2, ..., %99.
I suspect that the `%2` marker is just an unfortunate typo or the remainder of a string that used to have multiple numbered place markers.
This PR replaces the numbered place marker `%2` with `%1` to avoid any confusion in the future.
Tree-SHA512: 0bb40cf3b9824e1eeba0a184e72358b30d20e8261e12deb287155b7cc8317ad0b0787ef1d0671325eb8bccc9e51b3037d737015749338c31cf400930840e56b6
| -rw-r--r-- | src/qt/sendcoinsdialog.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/qt/sendcoinsdialog.cpp b/src/qt/sendcoinsdialog.cpp index 56b62f97fb..9fd61db70e 100644 --- a/src/qt/sendcoinsdialog.cpp +++ b/src/qt/sendcoinsdialog.cpp @@ -336,7 +336,7 @@ void SendCoinsDialog::on_sendButton_clicked() } questionString.append(tr("Total Amount %1") .arg(BitcoinUnits::formatHtmlWithUnit(model->getOptionsModel()->getDisplayUnit(), totalAmount))); - questionString.append(QString("<span style='font-size:10pt;font-weight:normal;'><br />(=%2)</span>") + questionString.append(QString("<span style='font-size:10pt;font-weight:normal;'><br />(=%1)</span>") .arg(alternativeUnits.join(" " + tr("or") + "<br />"))); questionString.append("<hr /><span>"); |