diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2017-10-04 14:35:15 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2017-10-04 14:35:43 +0200 |
| commit | e12522dfdaaba989c839b429cf3b3b34fd93d171 (patch) | |
| tree | 45249e97b37ad46065d57a588dadf0579915f832 | |
| parent | a4c833fec104457c9ed31885821c2e5bbc7c65c4 (diff) | |
| parent | 6643b80d1c0134bc8ef5edd65fbe09c8b63b01d3 (diff) | |
| download | bitcoin-e12522dfdaaba989c839b429cf3b3b34fd93d171.tar.xz | |
Merge #11406: Add state message print to AcceptBlock failure message.
6643b80 Add state message print to AcceptBlock failure message. (Matt Corallo)
Pull request description:
This should make it easier to debug issues where the CheckBlock at
the top of ProcessNewBlock fails (which does not print, in contrast
to AcceptBlock, which always prints).
This was motivated by #11371 which appears to be exactly such a case, and is not debuggable from the information provided. Not sure how much this would have helped in that case, but it is kinda weird that we can reject a block without ever printing why.
Tree-SHA512: 7a1c2c76080b810212da885c38e091609e409c62918cc326bb36a1096e09b2ae7e26fd4bdaefd79863d2894e2823e463005700a524940f177a59ef09f589b2f1
| -rw-r--r-- | src/validation.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/validation.cpp b/src/validation.cpp index a958afe84f..dafb02ee01 100644 --- a/src/validation.cpp +++ b/src/validation.cpp @@ -3192,7 +3192,7 @@ bool ProcessNewBlock(const CChainParams& chainparams, const std::shared_ptr<cons CheckBlockIndex(chainparams.GetConsensus()); if (!ret) { GetMainSignals().BlockChecked(*pblock, state); - return error("%s: AcceptBlock FAILED", __func__); + return error("%s: AcceptBlock FAILED (%s)", __func__, state.GetDebugMessage()); } } |