diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2016-09-15 23:32:45 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2016-09-15 23:42:01 +0200 |
| commit | d9c99c3058c90f4f7075cf5c495b8dcd2e7519a7 (patch) | |
| tree | b2f61948a223d43e509079ccd940a780711a0c60 | |
| parent | a82e5d8220bbc8b5d786bed99b0876f530b9b7cc (diff) | |
| download | bitcoin-d9c99c3058c90f4f7075cf5c495b8dcd2e7519a7.tar.xz | |
net: No longer send local address in addrMe
After #8594 the addrFrom sent by a node is not used anymore at all,
so don't bother sending it.
Also mitigates the privacy issue in (#8616). It doesn't completely solve
the issue as GetLocalAddress is also called in AdvertiseLocal, but at
least when advertising addresses it stands out less as *our* address.
| -rw-r--r-- | src/net.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/net.cpp b/src/net.cpp index cc9728b853..38b1e7926a 100644 --- a/src/net.cpp +++ b/src/net.cpp @@ -448,7 +448,7 @@ void CNode::PushVersion() { int64_t nTime = (fInbound ? GetAdjustedTime() : GetTime()); CAddress addrYou = (addr.IsRoutable() && !IsProxy(addr) ? addr : CAddress(CService(), addr.nServices)); - CAddress addrMe = GetLocalAddress(&addr, nLocalServices); + CAddress addrMe = CAddress(CService(), nLocalServices); if (fLogIPs) LogPrint("net", "send version message: version %d, blocks=%d, us=%s, them=%s, peer=%d\n", PROTOCOL_VERSION, nMyStartingHeight, addrMe.ToString(), addrYou.ToString(), id); else |