aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarcoFalke <falke.marco@gmail.com>2017-06-20 13:54:10 +0200
committerMarcoFalke <falke.marco@gmail.com>2017-06-20 13:55:05 +0200
commit999923e4bbc62920810d4d149a4938cfd657408a (patch)
treee417710a3b79b224357a4819aa9db0013ef2a396
parent643fa0b22d70e459d7f7ec3d728ae4811dc5158f (diff)
[qa] util: Check return code after closing bitcoind proc
This has no effect on the outcome of test cases, but prints shorter and less confusing tracebacks on fails. I.e. does not print an obvious "ConnectionRefusedError" when shutting down the nodes due to an invalid return code.
-rw-r--r--test/functional/test_framework/util.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/test/functional/test_framework/util.py b/test/functional/test_framework/util.py
index 2b0f32c2b6..8a2ac015fc 100644
--- a/test/functional/test_framework/util.py
+++ b/test/functional/test_framework/util.py
@@ -300,8 +300,8 @@ def _stop_node(node, i):
except http.client.CannotSendRequest as e:
logger.exception("Unable to stop node")
return_code = bitcoind_processes[i].wait(timeout=BITCOIND_PROC_WAIT_TIMEOUT)
- assert_equal(return_code, 0)
del bitcoind_processes[i]
+ assert_equal(return_code, 0)
def _stop_nodes(nodes):
"""Stop multiple bitcoind test nodes