aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMeshCollider <dobsonsa68@gmail.com>2017-11-12 17:11:26 +1300
committerMeshCollider <dobsonsa68@gmail.com>2017-12-20 18:47:56 +1300
commit1bab9b23af95986f9452d468257cc34d2c5017b2 (patch)
tree2b179c8097e4e834eac7c3131bf7d4265d360ea1
parent68c1e00a002dd2c5982105a6fae59eac2d2ce97b (diff)
downloadbitcoin-1bab9b23af95986f9452d468257cc34d2c5017b2.tar.xz
Add script dump note to RPC help text and release notes
-rw-r--r--doc/release-notes.md4
-rw-r--r--src/wallet/rpcdump.cpp2
2 files changed, 5 insertions, 1 deletions
diff --git a/doc/release-notes.md b/doc/release-notes.md
index 78caddc8f0..989e8d636d 100644
--- a/doc/release-notes.md
+++ b/doc/release-notes.md
@@ -100,6 +100,10 @@ The `share/rpcuser/rpcuser.py` script was renamed to `share/rpcauth/rpcauth.py`.
used to create `rpcauth` credentials for a JSON-RPC user.
+- `dumpwallet` now includes hex-encoded scripts from the wallet in the dumpfile, and
+ `importwallet` now imports these scripts, but corresponding addresses may not be added
+ correctly or a manual rescan may be required to find relevant transactions.
+
Credits
=======
diff --git a/src/wallet/rpcdump.cpp b/src/wallet/rpcdump.cpp
index 93f92f5153..92c3bd080c 100644
--- a/src/wallet/rpcdump.cpp
+++ b/src/wallet/rpcdump.cpp
@@ -613,7 +613,7 @@ UniValue dumpwallet(const JSONRPCRequest& request)
throw std::runtime_error(
"dumpwallet \"filename\"\n"
"\nDumps all wallet keys in a human-readable format to a server-side file. This does not allow overwriting existing files.\n"
- "Imported scripts are not currently included in wallet dumps, these must be backed up separately.\n"
+ "Imported scripts are included in the dumpfile, but corresponding BIP173 addresses, etc. may not be added automatically by importwallet.\n"
"Note that if your wallet contains keys which are not derived from your HD seed (e.g. imported keys), these are not covered by\n"
"only backing up the seed itself, and must be backed up too (e.g. ensure you back up the whole dumpfile).\n"
"\nArguments:\n"