diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-01-17 12:07:39 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-01-17 12:08:59 +0100 |
| commit | adce1de9a6ce5b41c4117b62f705bca53bf97216 (patch) | |
| tree | 007240e827d846e03a12cf19f7493d8fa66335be | |
| parent | 062c8b69f4ccae323d675685da8cbfcb7ccd0c55 (diff) | |
| parent | 49e5f3ff7e940b8da7d9e7252d2b1e27bd192ae4 (diff) | |
| download | bitcoin-adce1de9a6ce5b41c4117b62f705bca53bf97216.tar.xz | |
Merge #12198: rpc: Add deprecation error for `getinfo`
49e5f3f rpc: Add deprecation error for `getinfo` (Wladimir J. van der Laan)
Pull request description:
Add a short informative deprecation message when users use `getinfo`, that points them to the new calls
here to get the different information fields.
This is meant to be temporary, for one release only.
Tree-SHA512: 4fccd8853762d0740d051d9e74cdea5ad6f8d5c0ba67d69e8dd2ac8a1538d8270c1a1fab755d9f052ff3b3677753b09138c8c5ca0bc92d156de90413cd5c1814
| -rw-r--r-- | src/rpc/misc.cpp | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/src/rpc/misc.cpp b/src/rpc/misc.cpp index 95a27d474b..3bcad16316 100644 --- a/src/rpc/misc.cpp +++ b/src/rpc/misc.cpp @@ -668,6 +668,18 @@ UniValue echo(const JSONRPCRequest& request) return request.params; } +static UniValue getinfo_deprecated(const JSONRPCRequest& request) +{ + throw JSONRPCError(RPC_METHOD_NOT_FOUND, + "getinfo\n" + "\nThis call was removed in version 0.16.0. Use the appropriate fields from:\n" + "- getblockchaininfo: blocks, difficulty, chain\n" + "- getnetworkinfo: version, protocolversion, timeoffset, connections, proxy, relayfee, warnings\n" + "- getwalletinfo: balance, keypoololdest, keypoolsize, paytxfee, unlocked_until, walletversion\n" + "\nbitcoin-cli has the option -getinfo to collect and format these in the old format." + ); +} + static const CRPCCommand commands[] = { // category name actor (function) argNames // --------------------- ------------------------ ----------------------- ---------- @@ -682,6 +694,7 @@ static const CRPCCommand commands[] = { "hidden", "setmocktime", &setmocktime, {"timestamp"}}, { "hidden", "echo", &echo, {"arg0","arg1","arg2","arg3","arg4","arg5","arg6","arg7","arg8","arg9"}}, { "hidden", "echojson", &echo, {"arg0","arg1","arg2","arg3","arg4","arg5","arg6","arg7","arg8","arg9"}}, + { "hidden", "getinfo", &getinfo_deprecated, {}}, }; void RegisterMiscRPCCommands(CRPCTable &t) |