aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn Newbery <john@johnnewbery.com>2017-09-15 14:36:12 -0400
committerMarcoFalke <falke.marco@gmail.com>2017-10-03 22:03:09 +0200
commitf9cf7b589f430b2d7c52e477b6d62f29d748c38e (patch)
tree1e5e2eee186531531cf2b51bc5bbdaa6c7f609d3
parentf1ced0d7761d1316c6b522b2b426e79833e4cbae (diff)
downloadbitcoin-f9cf7b589f430b2d7c52e477b6d62f29d748c38e.tar.xz
[tests] Check connectivity before sending in assumevalid.py
assumevalid.py would try to send over a closed P2P connection in a loop, hitting the following failure many times: TestFramework.mininode (ERROR): Cannot send message. No connection to node! The test still passes, but this is a lot of noise in the test log. Just check that the connection is open before trying to send. Github-Pull: #11345 Rebased-From: e9e9391083721ca9733cc00a1907384f83b6435e
-rwxr-xr-xtest/functional/assumevalid.py2
1 files changed, 2 insertions, 0 deletions
diff --git a/test/functional/assumevalid.py b/test/functional/assumevalid.py
index beaf8c7055..65685c48b7 100755
--- a/test/functional/assumevalid.py
+++ b/test/functional/assumevalid.py
@@ -68,6 +68,8 @@ class AssumeValidTest(BitcoinTestFramework):
def send_blocks_until_disconnected(self, node):
"""Keep sending blocks to the node until we're disconnected."""
for i in range(len(self.blocks)):
+ if not node.connection:
+ break
try:
node.send_message(msg_block(self.blocks[i]))
except IOError as e: