diff options
author | Gregory Maxwell <greg@xiph.org> | 2016-11-27 02:47:22 +0000 |
---|---|---|
committer | Gregory Maxwell <greg@xiph.org> | 2016-11-27 04:13:54 +0000 |
commit | 083f20369878196785151e038e5f5126fed74021 (patch) | |
tree | c57369aeff2af76a042bca5a23f64ba321bf0ac7 | |
parent | 76fec09d878d6dbf214bdb6228d480bd9195db4c (diff) | |
download | bitcoin-083f20369878196785151e038e5f5126fed74021.tar.xz |
Remove fNetworkNode.
Matt pointed out to me that this appeared to be doing nothing (except involving itself in data races).
-rw-r--r-- | src/main.cpp | 4 | ||||
-rw-r--r-- | src/net.cpp | 5 | ||||
-rw-r--r-- | src/net.h | 1 |
3 files changed, 3 insertions, 7 deletions
diff --git a/src/main.cpp b/src/main.cpp index 6bb81fab24..4b6872146c 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -5242,8 +5242,8 @@ bool static ProcessMessage(CNode* pfrom, string strCommand, CDataStream& vRecv, { pfrom->SetRecvVersion(min(pfrom->nVersion, PROTOCOL_VERSION)); - // Mark this node as currently connected, so we update its timestamp later. - if (pfrom->fNetworkNode) { + if (!pfrom->fInbound) { + // Mark this node as currently connected, so we update its timestamp later. LOCK(cs_main); State(pfrom->GetId())->fCurrentlyConnected = true; } diff --git a/src/net.cpp b/src/net.cpp index ce87150ae3..08115a3518 100644 --- a/src/net.cpp +++ b/src/net.cpp @@ -1067,8 +1067,7 @@ void CConnman::ThreadSocketHandler() pnode->CloseSocketDisconnect(); // hold in disconnected pool until all refs are released - if (pnode->fNetworkNode || pnode->fInbound) - pnode->Release(); + pnode->Release(); vNodesDisconnected.push_back(pnode); } } @@ -1808,7 +1807,6 @@ bool CConnman::OpenNetworkConnection(const CAddress& addrConnect, bool fCountFai return false; if (grantOutbound) grantOutbound->MoveTo(pnode->grantOutbound); - pnode->fNetworkNode = true; if (fOneShot) pnode->fOneShot = true; if (fFeeler) @@ -2531,7 +2529,6 @@ CNode::CNode(NodeId idIn, ServiceFlags nLocalServicesIn, int nMyStartingHeightIn fOneShot = false; fClient = false; // set by version message fFeeler = false; - fNetworkNode = false; fSuccessfullyConnected = false; fDisconnect = false; nRefCount = 0; @@ -613,7 +613,6 @@ public: bool fOneShot; bool fClient; const bool fInbound; - bool fNetworkNode; bool fSuccessfullyConnected; bool fDisconnect; // We use fRelayTxes for two purposes - |