aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeff Garzik <jgarzik@exmulti.com>2012-05-14 12:21:03 -0400
committerJeff Garzik <jgarzik@redhat.com>2012-05-19 20:40:43 -0400
commitb52a27053850590e0ac8f1431a9aad50b7beffee (patch)
tree4fe681735ccbcf248f5bbd7ea049884fad25d04e
parentcde87ee75cd95b076259e146705bf34b66cd83aa (diff)
Reorganize(): remove spurious TxnAbort()
If Reorganize() fails, then its caller, CBlock::SetBestChain(), will call TxnAbort(). Redundant TxnAbort() calls are harmless. The second will return an error return value, with no other side effects. TxnAbort() return values are generally never checked. The impact is nil.
-rw-r--r--src/main.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/main.cpp b/src/main.cpp
index 8ff6d6fec0..f516ad65b5 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -1438,7 +1438,6 @@ bool static Reorganize(CTxDB& txdb, CBlockIndex* pindexNew)
if (!block.ConnectBlock(txdb, pindex))
{
// Invalid block
- txdb.TxnAbort();
return error("Reorganize() : ConnectBlock %s failed", pindex->GetBlockHash().ToString().substr(0,20).c_str());
}