diff options
| author | fanquake <fanquake@gmail.com> | 2023-12-12 13:27:05 +0000 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-12-12 13:43:06 +0000 |
| commit | a7484be65f7617d77aff92ecf6f5fb26015d27a8 (patch) | |
| tree | 616f4f8ce65097fd2c1dfa520cf9ae914adcccc4 | |
| parent | 60f677375e52832536a599afae3226f8e2155d88 (diff) | |
| parent | 7b22cd80e050b903b5765133b8116f4b17ce0296 (diff) | |
Merge bitcoin/bitcoin#29059: Revert "ci: Only run functional tests on windows in master"
7b22cd80e050b903b5765133b8116f4b17ce0296 Revert "ci: Only run functional tests on windows in master" (Hennadii Stepanov)
Pull request description:
This PR reverts commit aba4a5887b44bf7cbee9ea0a8e02bb92c1b4147b from https://github.com/bitcoin/bitcoin/pull/28567.
The Windows-specific code received [quality](https://github.com/bitcoin/bitcoin/pull/28486) and [performance](https://github.com/bitcoin/bitcoin/pull/29045) improvements recently. So there are no reasons to skip functional tests in PRs anymore.
In my own repo, I've run the GHA Windows job more than 100 times with no failure.
ACKs for top commit:
maflcko:
lgtm ACK 7b22cd80e050b903b5765133b8116f4b17ce0296
TheCharlatan:
ACK 7b22cd80e050b903b5765133b8116f4b17ce0296
Tree-SHA512: 1e8687e8efe12db506e7cd2d5df9e48b5acb98a339f84684dd0fd67280e22227e2a5a206f1108b09e49038fab7a3ca2ffbd985677f00048c0962b39b2b9a2ba5
| -rw-r--r-- | .github/workflows/ci.yml | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1b43eca672..c8c4cfa583 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -282,10 +282,6 @@ jobs: run: py -3 test\util\rpcauth-test.py - name: Run functional tests - # Don't run functional tests for pull requests. - # The test suit regularly fails to complete in windows native github - # actions as a child process stops making progress. The root cause has - # not yet been determined. - # Discussed in https://github.com/bitcoin/bitcoin/pull/28509 - if: github.event_name != 'pull_request' - run: py -3 test\functional\test_runner.py --jobs $env:NUMBER_OF_PROCESSORS --ci --quiet --tmpdirprefix=$env:RUNNER_TEMP --combinedlogslen=99999999 --timeout-factor=$env:TEST_RUNNER_TIMEOUT_FACTOR --extended + env: + TEST_RUNNER_EXTRA: ${{ github.event_name != 'pull_request' && '--extended' || '' }} + run: py -3 test\functional\test_runner.py --jobs $env:NUMBER_OF_PROCESSORS --ci --quiet --tmpdirprefix=$env:RUNNER_TEMP --combinedlogslen=99999999 --timeout-factor=$env:TEST_RUNNER_TIMEOUT_FACTOR $env:TEST_RUNNER_EXTRA |