diff options
| author | Giel van Schijndel <me@mortis.eu> | 2011-06-24 20:09:24 +0200 |
|---|---|---|
| committer | Giel van Schijndel <me@mortis.eu> | 2011-07-13 05:07:44 +0200 |
| commit | d7f1d200ab5d385c727261621c069dfbc6170e78 (patch) | |
| tree | 3b2eff1191b8423f36540065d2a84c178d77e6cd | |
| parent | f85c0974492d9c779d45112fc943f0dbe0b95cda (diff) | |
fix warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
Don't check for a negative parameter count, because not only will it
never happen, it doesn't make any sense either.
Invalid sockets (as returned by socket(2)) are always exactly -1 (not
just negative as negative file descriptors are technically not
prohibited by POSIX) on POSIX systems. Since we store them in SOCKET
(unsigned int), however, that really is ~0U (or MAX_UINT) which happens
to be what INVALID_SOCKET is already defined to, so an additional check
for being negative is not only unnecessary (unsigned integers aren't
*ever* negative) its redundant as well (the INVALID_SOCKET comparison is
enough).
Signed-off-by: Giel van Schijndel <me@mortis.eu>
| -rw-r--r-- | src/net.cpp | 2 | ||||
| -rw-r--r-- | src/rpc.cpp | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/net.cpp b/src/net.cpp index 0d3348da72..da13874495 100644 --- a/src/net.cpp +++ b/src/net.cpp @@ -831,7 +831,7 @@ void ThreadSocketHandler2(void* parg) { BOOST_FOREACH(CNode* pnode, vNodes) { - if (pnode->hSocket == INVALID_SOCKET || pnode->hSocket < 0) + if (pnode->hSocket == INVALID_SOCKET) continue; FD_SET(pnode->hSocket, &fdsetRecv); FD_SET(pnode->hSocket, &fdsetError); diff --git a/src/rpc.cpp b/src/rpc.cpp index fbed626a84..e71c5bcb40 100644 --- a/src/rpc.cpp +++ b/src/rpc.cpp @@ -706,7 +706,7 @@ int64 GetAccountBalance(const string& strAccount, int nMinDepth) Value getbalance(const Array& params, bool fHelp) { - if (fHelp || params.size() < 0 || params.size() > 2) + if (fHelp || params.size() > 2) throw runtime_error( "getbalance [account] [minconf=1]\n" "If [account] is not specified, returns the server's total available balance.\n" |