diff options
author | kevkevin <oapallikunnel@gmail.com> | 2023-11-06 20:39:03 -0600 |
---|---|---|
committer | kevkevin <oapallikunnel@gmail.com> | 2023-11-08 14:45:18 -0600 |
commit | b4b01d3fb42e7b688d97b75f57cfe18cfca6d943 (patch) | |
tree | 592cbba9e7b1daba693d931b01da24164483ac1f | |
parent | 83933eff00335415477f969147ab321824dcc4e8 (diff) |
[refactor] updating miniminer comments to be more accurate
-rw-r--r-- | src/node/mini_miner.h | 8 | ||||
-rw-r--r-- | src/test/miniminer_tests.cpp | 4 |
2 files changed, 6 insertions, 6 deletions
diff --git a/src/node/mini_miner.h b/src/node/mini_miner.h index 67d40b2cce..de62c0af75 100644 --- a/src/node/mini_miner.h +++ b/src/node/mini_miner.h @@ -137,10 +137,10 @@ public: */ MiniMiner(const CTxMemPool& mempool, const std::vector<COutPoint>& outpoints); - /** Constructor in which the MiniMinerMempoolEntry entries have been constructed manually, - * presumably because these transactions are not in the mempool (yet). It is assumed that all - * entries are unique and their values are correct, otherwise results computed by MiniMiner may - * be incorrect. Callers should check IsReadyToCalculate() after construction. + /** Constructor in which the MiniMinerMempoolEntry entries have been constructed manually. + * It is assumed that all entries are unique and their values are correct, otherwise results + * computed by MiniMiner may be incorrect. Callers should check IsReadyToCalculate() after + * construction. * @param[in] descendant_caches A map from each transaction to the set of txids of this * transaction's descendant set, including itself. Each tx in * manual_entries must have a corresponding entry in this map, and diff --git a/src/test/miniminer_tests.cpp b/src/test/miniminer_tests.cpp index 036d3b5d5d..2531ea7c47 100644 --- a/src/test/miniminer_tests.cpp +++ b/src/test/miniminer_tests.cpp @@ -646,7 +646,7 @@ BOOST_FIXTURE_TEST_CASE(manual_ctor, TestChain100Setup) CTxMemPool& pool = *Assert(m_node.mempool); LOCK2(cs_main, pool.cs); { - // 3 pairs of fee-bumping grandparent + parent, plus 1 low-feerate child. + // 3 pairs of grandparent + fee-bumping parent, plus 1 low-feerate child. // 0 fee + high fee auto grandparent_zero_fee = make_tx({{m_coinbase_txns.at(0)->GetHash(), 0}}, 1); auto parent_high_feerate = make_tx({{grandparent_zero_fee->GetHash(), 0}}, 1); @@ -692,7 +692,7 @@ BOOST_FIXTURE_TEST_CASE(manual_ctor, TestChain100Setup) BOOST_CHECK_EQUAL(sequences.at(grandparent_double_low_feerate->GetHash()), 1); BOOST_CHECK_EQUAL(sequences.at(parent_med_feerate->GetHash()), 1); - // CPFP low + med + // CPFP low + double low BOOST_CHECK_EQUAL(sequences.at(grandparent_low_feerate->GetHash()), 2); BOOST_CHECK_EQUAL(sequences.at(parent_double_low_feerate->GetHash()), 2); |