diff options
author | fanquake <fanquake@gmail.com> | 2019-10-13 19:28:58 -0400 |
---|---|---|
committer | fanquake <fanquake@gmail.com> | 2019-10-15 09:48:50 -0400 |
commit | cc3b5289ef648dca30469ee4afa615a1ed5b4e04 (patch) | |
tree | ed7ba9d5b673f349bf951b8d826edadf4a370081 /.style.yapf | |
parent | 029c65e04cc2826817e6b5b10696c0e390694ae8 (diff) |
gui: remove OpenSSL PRNG seeding (Windows, Qt only)
This removes the code introduced in [#4399](https://github.com/bitcoin/bitcoin/pull/4399)
that attempts to add additional entroy to the OpenSSL PRNG using Windows messages.
Note that this is specific to bitcoin-qt running on Windows.
```
RAND_event() collects the entropy from Windows events such as mouse movements and other user interaction.
It should be called with the iMsg, wParam and lParam arguments of all messages sent to the window procedure.
It will estimate the entropy contained in the event message (if any), and add it to the PRNG.
The program can then process the messages as usual.
```
Besides BIP70, this is the last place we are directly using OpenSSL in the
GUI code. All other OpenSSL usage is in random.cpp.
Note that we are still also doing Windows specific entropy gathering in multiple
other places. Such as [RandAddSeedPerfmon](https://github.com/bitcoin/bitcoin/blob/master/src/random.cpp#L268)
and [RAND_screen()](https://github.com/bitcoin/bitcoin/blob/master/src/random.cpp#L600).
Also note that if RAND_event returns 0 (PRNG has NOT been seeded with enough data), we're
just logging a message and continuing on, which seems less than ideal.
Diffstat (limited to '.style.yapf')
0 files changed, 0 insertions, 0 deletions