diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-02-13 18:43:23 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-02-13 18:50:02 +0100 |
| commit | 470664f2b788e2cce9202991d11476a6fef00ef4 (patch) | |
| tree | 0dc207b063623014f2c13964e19b95c1ef853cbf /.gitignore | |
| parent | 0c20809da85ac708386fa1ca80f7242917f90761 (diff) | |
| parent | 25bc17fceb08ee9625c5e09e2579117ec6f7a1c5 (diff) | |
| download | bitcoin-470664f2b788e2cce9202991d11476a6fef00ef4.tar.xz | |
Merge #17746: refactor: rpc: Remove vector copy from listtransactions
25bc17fceb08ee9625c5e09e2579117ec6f7a1c5 refactor: rpc: Remove vector copy from listtransactions (João Barbosa)
Pull request description:
Current approach
- copy accumulated `ret` vector to `arrTmp`
- drop unnecessary elements from `arrTmp`
- reverse `arrTmp`
- clear `ret`
- copy `arrTmp` to the `ret`
New approach
- create a vector from the accumulated `ret` with just the necessary elements already reversed
- copy it to the result
This PR doesn't change behavior.
ACKs for top commit:
ryanofsky:
Code review ACK 25bc17fceb08ee9625c5e09e2579117ec6f7a1c5. Just comment and commit message tweaks since last review
Tree-SHA512: 87906561e3accdbdb0f4a8194cbcd76ea53ae53d0ce135b90bc54a5f77e300b14ef08505e7daf1fe52426f135442a743da5a027416a769bd454922357cebe7c0
Diffstat (limited to '.gitignore')
0 files changed, 0 insertions, 0 deletions