diff options
| author | Andrew Chow <github@achow101.com> | 2023-09-20 13:43:37 -0400 |
|---|---|---|
| committer | Andrew Chow <github@achow101.com> | 2023-09-20 13:50:15 -0400 |
| commit | 8247a8db6963d2116dc4697a3217d736c197f91d (patch) | |
| tree | 41f5bbb30b99753cf63e5b30255ee1f37d286adb /.github | |
| parent | 99ce8366ed949a1e8a42c1562867b0330b78b212 (diff) | |
| parent | 83d7cfd5429b0be7755bc48145032956f5f56dae (diff) | |
Merge bitcoin/bitcoin#28154: test: refactor: deduplicate segwitv0 ECDSA signing for tx inputs
83d7cfd5429b0be7755bc48145032956f5f56dae test: refactor: deduplicate segwitv0 ECDSA signing for tx inputs (Sebastian Falbesoner)
Pull request description:
This PR is a simple follow-up for #28025. It introduces a `signing_input_segwitv0` helper in order to deduplicate the following steps needed to create a segwitv0 ECDSA signature:
1. calculate the `SegwitV0SignatureHash` with the desired sighash type
2. create the actual digital signature by calling ECKey.sign_ecdsa on the signature message hash calculated above
3. put the DER-encoded result (plus sighash byte) at the bottom of the witness stack
ACKs for top commit:
achow101:
ACK 83d7cfd5429b0be7755bc48145032956f5f56dae
pinheadmz:
code review ACK at 83d7cfd5429b0be7755bc48145032956f5f56dae
Tree-SHA512: b8e55409ddc9ddb14cfc06daeb4730d7750a4632f175f88dcac6ec4d216e71fd4a7eee325a64d6ebba3b33be50bcd30c2de7400f834c01abb67e52840d9823b6
Diffstat (limited to '.github')
0 files changed, 0 insertions, 0 deletions