diff options
| author | Ava Chow <github@achow101.com> | 2023-12-13 12:38:11 -0500 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2023-12-13 12:45:30 -0500 |
| commit | 9f0f83d6509a214b827f5110c0f857b494ae854c (patch) | |
| tree | a123dcbc3de342e3beff789008db7f0f18b4ec93 /.github/workflows/ci.yml | |
| parent | 019ec8a601c91e89a16e55d79ec60cfa29254094 (diff) | |
| parent | 37c75c58202f89b752500f76c872d7f8caf6bdb3 (diff) | |
Merge bitcoin/bitcoin#29065: bench: wallet, fix change position out of range error
37c75c58202f89b752500f76c872d7f8caf6bdb3 test: wallet, fix change position out of range error (furszy)
Pull request description:
Fixes #29061. Only the benchmark is affected.
Since #25273, the behavior of 'inserting change at a random position'
is instructed by passing ´std::nullopt´ instead of -1.
Also, added missing documentation about the meaning of
'change_pos=std::nullopt' inside 'CWallet::CreateTransaction()'
ACKs for top commit:
achow101:
ACK 37c75c58202f89b752500f76c872d7f8caf6bdb3
kevkevinpal:
ACK [37c75c5](https://github.com/bitcoin/bitcoin/pull/29065/commits/37c75c58202f89b752500f76c872d7f8caf6bdb3)
BrandonOdiwuor:
ACK 37c75c58202f89b752500f76c872d7f8caf6bdb3
Tree-SHA512: d9a8d8533540455716a5090fcf407573cad9f0d0018a05f903f89e51620302f9b256318db6f7338b85c047f7fab372d724e916b1721d7ed302dbf3d845b08734
Diffstat (limited to '.github/workflows/ci.yml')
0 files changed, 0 insertions, 0 deletions