diff options
| author | Murch <murch@murch.one> | 2022-02-09 15:41:53 -0500 |
|---|---|---|
| committer | Murch <murch@murch.one> | 2022-02-14 16:01:26 -0500 |
| commit | e50a9be1540c769a99fcdc1f7a109a6bf1c7516b (patch) | |
| tree | f1c00187b9337f6b99f864a761897f7ad5e74044 /.github/PULL_REQUEST_TEMPLATE.md | |
| parent | 5e8e0b3d7f6055e326bda61e60712b530e8920f0 (diff) | |
Remove outdated comment on CFeeRate
This comment described how the constructor of CFeeRate was previously
indirectly used to parse fee rate arguments from RPCs. The command line
input was actually in sat/vB but due to the use of AmountFromValue() it
got converted to BTC/vB. In the constructor this could be rectified by
creating a CFeeRate from that given value (in BTC/vB) and COIN as the
transaction size, turning the input effectively to sat/vB. Since this
usage pattern was removed from the codebase some months ago, the comment
is now obsolete.
Also:
• Use vsize and vbyte instead of size and byte
Diffstat (limited to '.github/PULL_REQUEST_TEMPLATE.md')
0 files changed, 0 insertions, 0 deletions