diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-12-08 18:47:38 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-12-08 18:49:02 +0100 |
| commit | e98d1d674091681f88c5872f3e3923e37ce81b00 (patch) | |
| tree | c916a17f54393e2292e9583e84e94d6193221bd2 /.github/ISSUE_TEMPLATE | |
| parent | 16b31cc4c516cdcaf6d2eb2dd1255cc3e6973ba1 (diff) | |
| parent | 5baa88fd38c8efa0e361636bb2c60af89d27b5d5 (diff) | |
Merge #19425: refactor: Get rid of more redundant chain methods
5baa88fd38c8efa0e361636bb2c60af89d27b5d5 test: Remove no longer needed MakeChain calls (Russell Yanofsky)
6965f1352d2d7086d308750ce83a84f191a17755 refactor: Replace uses ChainActive() in interfaces/chain.cpp (Russell Yanofsky)
3fbbb9a6403a86fbed3d5d9f7939998922593377 refactor: Get rid of more redundant chain methods (Russell Yanofsky)
Pull request description:
This just drops three interfaces::Chain methods replacing them with other calls.
Motivation for removing these chain methods:
- Need to get rid of findFirstBlockWithTimeAndHeight for #10102, which doesn't support overloaded methods
- Followup from https://github.com/bitcoin/bitcoin/pull/16426#discussion_r412487403
- phantomcircuit comments about findNextBlock test http://www.erisian.com.au/bitcoin-core-dev/log-2020-06-06.html#l-214
Behavior is not changing in any way here. A TODO comment in ScanForWalletTransactions was removed, but just because it was invalid (see https://github.com/bitcoin/bitcoin/pull/19195#discussion_r448020762), not because it was implemented.
ACKs for top commit:
MarcoFalke:
re-ACK 5baa88fd38c8efa0e361636bb2c60af89d27b5d5 🕶
dongcarl:
ACK 5baa88fd38c8efa0e361636bb2c60af89d27b5d5
Tree-SHA512: d20a2a8cf8742e6100c6d3a4871ed67f184925712cf9e55d301abee60353bf3f74cd0d46a13be1715d1c2faef72102bb321654d08a128c2ef6880f72b72a6687
Diffstat (limited to '.github/ISSUE_TEMPLATE')
0 files changed, 0 insertions, 0 deletions