diff options
| author | fanquake <fanquake@gmail.com> | 2019-12-01 11:56:52 -0500 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2019-12-01 12:23:44 -0500 |
| commit | 19698ac6bc0e6c75a92b02c8b74ae1fa51c34e08 (patch) | |
| tree | df9e5c79831e18ca0dd102da7a0657ea632a1470 /.github/ISSUE_TEMPLATE | |
| parent | 2ecb7e1556cd970b6dccb5f101a718602487df4b (diff) | |
| parent | eadd1304c81e0b89178e4cc7630bd31650850c85 (diff) | |
Merge #17568: wallet: fix when sufficient preset inputs and subtractFeeFromOutputs
eadd1304c81e0b89178e4cc7630bd31650850c85 tests: Add a test for funding with sufficient preset inputs and subtractFeeFromOutputs (Andrew Chow)
ff330badd45067cb520b1cfa1844f60a4c9f2031 Default to bnb_used = false as there are many cases where BnB is not used (Andrew Chow)
Pull request description:
#17290 introduced a bug where, when we had preset inputs that covered the amount being sent and subtractFeeFrromOutputs was being used, transaction funding would result in a `Fee exceeds maximum configured by -maxtxfee` error. This was happening because we weren't setting `bnb_used = false` when the preset inputs were used as it should have been. This resulted in a too high fee because the change would go to fees accidentally.
Apparently this particular case doesn't have a test, so I've added one as well.
ACKs for top commit:
Sjors:
ACK eadd130. I can't get this new test to fail on macOS (without this PR). It passes whether or not I compile with `--enable-debug`. It does fail on Ubuntu. Yay undefined behavior... Anyway, it's a useful test.
fanquake:
ACK eadd1304c81e0b89178e4cc7630bd31650850c85
instagibbs:
utACK https://github.com/bitcoin/bitcoin/pull/17568/commits/eadd1304c81e0b89178e4cc7630bd31650850c85
Tree-SHA512: 7286c321f78666eea558cc591174630d210263594df41cab1065417510591ee514ade0e1d0cec8af09a785757da68de82592b013e8fe8d4966cec3254368706e
Diffstat (limited to '.github/ISSUE_TEMPLATE')
0 files changed, 0 insertions, 0 deletions