diff options
| author | laanwj <126646+laanwj@users.noreply.github.com> | 2022-02-17 13:30:10 +0100 |
|---|---|---|
| committer | laanwj <126646+laanwj@users.noreply.github.com> | 2022-02-17 14:10:13 +0100 |
| commit | 922c49a1389531d9fba30168257c466bd413f625 (patch) | |
| tree | 1a41496e44547300b6fbff5e454e5e9588c4d5b0 /.cirrus.yml | |
| parent | df0825046acc7cb496c47666e36af18118beb030 (diff) | |
| parent | eb8b22d5176d7abc6f93b4473df446105ca595e6 (diff) | |
| download | bitcoin-922c49a1389531d9fba30168257c466bd413f625.tar.xz | |
Merge bitcoin/bitcoin#23819: ConnectBlock: don't serialize block hash twice
eb8b22d5176d7abc6f93b4473df446105ca595e6 block_connected: re-use previous GetTimeMicros (William Casarin)
80e1c55687aae61767f1ade0826746cda00d6a24 block_connected: don't serialize block hash twice (William Casarin)
Pull request description:
In the validation:block_connected tracepoint, we call block->GetHash(), which
ends up calling CBlockHeader::GetHash(), executing around 8000 serialization
instructions. We don't need to do this extra work, because block->GetHash() is
already called further up in the function. Let's save that value as a local
variable and re-use it in our tracepoint so there is no unnecessary tracepoint
overhead.
Shave off an extra 100 or so instructions from the validation:block_connected
tracepoint by reusing a nearby GetTimeMicros(). This brings the tracepoint down
to 54 instructions. Still high, but much better than the previous ~154 and
8000 instructions which it was originally.
Signed-off-by: William Casarin <jb55@jb55.com>
ACKs for top commit:
0xB10C:
ACK eb8b22d5176d7abc6f93b4473df446105ca595e6
laanwj:
Code review ACK eb8b22d5176d7abc6f93b4473df446105ca595e6
theStack:
re-ACK eb8b22d5176d7abc6f93b4473df446105ca595e6
Tree-SHA512: 92ae585e487554e0f73042a8abaa239f630502c1d198e010bd7c1de252d882bccb627bbf0e4faec09c1253e782b145bcf153f9fee78cdb8456188044a96f8267
Diffstat (limited to '.cirrus.yml')
0 files changed, 0 insertions, 0 deletions