summaryrefslogtreecommitdiff
path: root/bip-0174.mediawiki
AgeCommit message (Collapse)Author
2021-02-04Merge remote-tracking branch 'origin-pull/1036/head'Luke Dashjr
2021-02-03Merge pull request #988 from dr-orlovsky/patch-1Luke Dashjr
BIP 174: require creator to initialize empty output fields
2021-02-03BIP 174: Revert title change to fit length limitLuke Dashjr
This partially reverts c0991047e25a35d1ddf241f304a079e9893eed69.
2021-01-25Combine Appendix with field listing tablesAndrew Chow
2021-01-25Mark BIP 174 as finalAndrew Chow
2021-01-15Include PSBT versions that can or must include fieldAndrew Chow
2021-01-15Specify procedure for new fields and versionsAndrew Chow
2021-01-15Explicitly specify PSBTv0Andrew Chow
2021-01-14Reformat BIP 174Andrew Chow
2021-01-13BIP 174: clarify format of proprietary extensions.Rusty Russell
"Variable length string identifier" is not defined anywhere, and the suggestion to use "0x00" is also deeply unclear. I assumed it meant a nul-terminated string! Be explicit: you mean it must be a compact siz1\e unsigned int length, followed by that many identifier bytes, followed by a compact size unsigned int subtype, followed by optional keydata. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-11-16fixed input test case description as per output test case descriptionFerdinando M. Ametrano
2020-11-15fixed typosfametrano
2020-10-05Merge pull request #981 from apoelstra/2020-08-rename-hash-preimagesLuke Dashjr
BIP174: add `_IN_` to names of new hash preimage fields
2020-10-05Merge pull request #990 from dr-orlovsky/patch-3Luke Dashjr
BIp 174: fixing typo in rationale reference with closed tag
2020-09-08BIp 174: fixing typo in rationale reference with closed tagDr. Maxim Orlovsky
2020-09-07BIP 174: removing extra "fields" wordDr. Maxim Orlovsky
2020-09-07BIP 174: rename responsibilities->roles to match Bitcoin CoreDr. Maxim Orlovsky
[Bitcoin Core uses "roles" instead of "responsibilities"](https://github.com/bitcoin/bitcoin/blob/master/src/psbt.h#L559) and it makes semantical sense (plus less verbose).
2020-09-07Require creator to initialize empty output fieldsDr. Maxim Orlovsky
The current version of the spec requires creator role to initialize empty input fields, but says nothing about output field initialization. At the same time, the following role, updater, "should also add redeemScripts, witnessScripts, and BIP 32 derivation paths to the input and output data if it knows them.", which does not make any sense if the fields were uninitialized. The [current Bitcoin Core implementation does this](https://github.com/bitcoin/bitcoin/blob/a24806c25d7a81a9c436de58eb5778d93abab16b/src/psbt.cpp#L12), and [other PSBT implementations, like rust-bitcoin, follow this practice](https://github.com/rust-bitcoin/rust-bitcoin/blob/master/src/util/psbt/mod.rs#L59)
2020-08-27bip 174: add new hash preimage fields to Appendix AAndrew Poelstra
2020-08-26bip174: add `_IN_` to new hash preimage fieldsAndrew Poelstra
2020-08-20Merge pull request #964 from sanket1729/masterLuke Dashjr
BIP 174: Fix formatting changes
2020-08-20Merge pull request #955 from apoelstra/2020-07-hash-preimages-to-174Luke Dashjr
BIP174: add hash preimage fields to inputs
2020-08-11BIP174: add hash preimage fields to inputsAndrew Poelstra
2020-08-04Fix formatting changesSanket Kanjalkar
2020-07-21BIP174: Clarify that both UTXO types are allowedAndrew Chow
2020-06-09bip-0174: Input Finalizer finalized fields clarificationsMike Schmidt
2020-01-03Merge pull request #869 from benthecarman/patch-2Luke Dashjr
BIP 174: Specify that separator only appears at end of the map
2019-12-14BIP-174: add missing types to Appendix A; fix proprietary type namesDmitry Petukhov
PSBT_INPUT_PROPRIETARY -> PSBT_IN_PROPRIETARY PSBT_OUTPUT_PROPRIETARY -> PSBT_OUT_PROPRIETARY to be consistent with other in/out type names that use shortened `IN` and `OUT`
2019-12-13Merge pull request #860 from azuchi/fix-wrong-description-bip174Luke Dashjr
BIP174: Fix wrong description about Proprietary Use Type
2019-12-13Merge pull request #866 from dgpv/patch-6Luke Dashjr
BIP174: remove 'first byte is the type' comment for key data
2019-12-13Merge pull request #867 from dgpv/patch-7Luke Dashjr
BIP-174: test data: fix value length
2019-12-11BIP 174: Specify that separator only appears at end of the mapBen Carman
2019-12-09BIP-174: test data: fix value lengthDmitry Petukhov
In the test case "Case: PSBT With invalid output witnessScript typed key", after PSBT_OUT_WITNESS_SCRIPT key with garbage data (which ends with `...478ef51309d`, follows value `2b` which would denote the length of the data value of the key. But the length of actual remaining data is only 7 bytes. Thus, an implementation that reads key-value pairs and checks for validity of the key data after it has read the current key-value pair, will not be able to hit the exact condition intended for this test case: extra data within the key itself. This is because such implementation will hit serialization error when it will try to read the data of the value and will get the short read. Reading full key-value pair and then checking key format afterwards is fairly normal thing to do, as the format of the keys with all their meaning is an abstraction of higher level than just the simple key-value serialization format. The proposed change is to replace byte `2b` after the key data to `06` and thus make the value length in the key-value pair valid (not going beyond the end of the data). base64 encoding has been changed accordingly.
2019-12-09Specify 32 bit itns as unsigned and their endianessBen Carman
2019-12-09BIP174: remove 'first byte is the type' comment for key dataDmitry Petukhov
As the key type is now defined as compact size integer, `At the beginning of each key is a compact size unsigned integer representing the type`, the comment in the first table in the document, about first byte of the key being the key type is no longer accurate. As the structure of the key data is described further in the text after the table, and the comment that it starts with the compact size integer seems a bit long to be in that table, I think it is better to just remove the comment about the key data structure from the table, and leave the explanation to the text after the table.
2019-11-14BIP174: Fix wrong description about Proprietary Use Typeazuchi
2019-11-04Merge pull request #844 from kallerosenbaum/masterLuke Dashjr
BIP174: Remove misleading sentence
2019-11-04Merge pull request #849 from achow101/bip174-extensionsLuke Dashjr
Bip174 extensions
2019-10-02Specify proprietary use typeAndrew Chow
2019-09-20BIP174: Remove misleading sentenceKalle Rosenbaum
The sentence seems to suggest that the "master key fingerprint" can be the fingerprint of any intermediate node on the derivation path, which isn't true.
2019-09-20Merge pull request #810 from NicolasDorier/bips/global-xpub-test-vectorLuke Dashjr
bip174: Add test vector for global xpub
2019-09-20Merge pull request #842 from darosior/174_typoLuke Dashjr
Remove a typo in bip-0174
2019-09-19Merge pull request #796 from lukechilds/patch-2Luke Dashjr
[bip174] Fix typo in signer pseudo code
2019-09-16bip-0174: remove duplicated 'only' (typo)darosior
2019-08-01Specify that types are compact size unsigned ints to allow for multi-byte typesAndrew Chow
2019-08-01Add Version typeAndrew Chow
2019-07-26bip174: Add test vector for global xpubnicolas.dorier
2019-07-25BIP 174: global xpubs serialization test vectorAndrew Chow
2019-07-23Merge pull request #800 from junderw/junderw-patch-1Luke Dashjr
BIP174: Include suggested sighash check
2019-07-10BIP174: Include suggested sighash checkJonathan Underwood
generated by cgit v1.2.3 (git 2.26.2) at 2024-11-19 06:59:12 +0000