summaryrefslogtreecommitdiff
path: root/bip-0174.mediawiki
AgeCommit message (Collapse)Author
2022-05-05Merge pull request #1290 from allenpiscitello/patch-1Luke Dashjr
Fixing incorrect allowing of unsigned transaction
2022-04-04Correct pubkey type for TAP_INTERNAL_KEYBrandon Black
2022-04-04Fix data type for TAP_MERKLE_ROOTBrandon Black
2022-04-04Remove repeated clauseBrandon Black
2022-03-24Fixing incorrect allowing of unsigned transactionallenpiscitello
V2 does not allow Global Key Type of 0 (Unsigned Transaction), but not listed as excluded in the spec.
2022-01-16Merge pull request #1270 from JeremyRubin/patch-2Luke Dashjr
[BIP-174] Clarify that partial_sig should be a valid.
2022-01-12bip174: document PSBT 0 handling of type > 0xFDSjors Provoost
2022-01-12bip174: link to 'compact size' definitionSjors Provoost
2022-01-08[BIP-174] Clarify that partial_sig should be a valid.Jeremy Rubin
2022-01-06BIP-174: Remove PSBT_GLOBAL_SIGHASH_SINGLE_INPUTDr Maxim Orlovsky
2021-11-23BIP-174: Removing PSBT_OUT_TAP_LEAF_SCRIPTDr. Maxim Orlovsky
`PSBT_OUT_TAP_LEAF_SCRIPT` seemed to appear in output key sections by copy-paste from input section. First, it shares the same byte no as `PSBT_OUT_TAP_TREE`, second its description talks about "witness"
2021-10-27BIP 0174: Clarify use of PSBT_IN_FINAL_* when data is emptyKalle Rosenbaum
2021-09-30Merge pull request #1198 from kallerosenbaum/patch-2kallewoof
BIP 0174: Fix typo in PSBT_OUT_BIP32_DERIVATION
2021-09-29Fix typo in PSBT_OUT_BIP32_DERIVATIONKalle Rosenbaum
2021-09-29Correct format of PSBT_GLOBAL_TX_MODIFIABLEKalle Rosenbaum
The descriptions for this field differ between bip370 and bip174. I suppose the correct format of PSBT_GLOBAL_TX_MODIFIABLE is the one in BIP370.
2021-08-15[BIP174] Fix broken link to psbt2azuchi
2021-07-20Specify BIP 371 Taproot Fields for PSBTAndrew Chow
Add bip-0371.mediawiki, update readme, and update BIP 174 with new field types.
2021-06-21psbt2: Fix field number countingAndrew Chow
PSBT_OUT_SCRIPT should be 0x04, not 0x03.
2021-05-11BIP 174: clarify key uniquenesst-bast
The description of keytype incorrectly said it had to be unique: it's the whole key that must be unique, not the keytype (since we can for instance have multiple xpubs in the global map).
2021-04-22Merge pull request #1099 from achow101/more-psbt-testsLuke Dashjr
BIP 174: Add test vectors for additional unsigned tx serialization
2021-04-08BIP 174: Add test vectors for additional unsigned tx serializationAndrew Chow
There are some edge cases with unsigned tx serialization, so this adds test vectors for them. Specifically, an unsigned tx with witness serialization is invalid, a transaction with 0 inputs and 0 outputs is valid, and a transaction with 0 inputs and non-0 outputs is valid.
2021-03-31Update bip-0174.mediawikikiminuo
I, personally, find this easier to read.
2021-03-15Merge pull request #1078 from dr-orlovsky/patch-5Luke Dashjr
Fixing Simple Signer Algorithm
2021-03-15Merge BIP 370Luke Dashjr
2021-03-04174: Change PSBT unknown fields test to use higher numbersAndrew Chow
Previously these tests were using 0x0f as the unknown field number. As these have now been defined, change them to use 0xf0 instead as it is unlikely we will use those anything soon.
2021-03-02Fixing Simple Signer AlgorithmDr. Maxim Orlovsky
Simple Signer Algorithm was lacking an index argument (last one) on all function calls
2021-02-12Specify BIP 370 PSBTv2Andrew Chow
2021-02-04Merge remote-tracking branch 'origin-pull/1036/head'Luke Dashjr
2021-02-03Merge pull request #988 from dr-orlovsky/patch-1Luke Dashjr
BIP 174: require creator to initialize empty output fields
2021-02-03BIP 174: Revert title change to fit length limitLuke Dashjr
This partially reverts c0991047e25a35d1ddf241f304a079e9893eed69.
2021-01-25Combine Appendix with field listing tablesAndrew Chow
2021-01-25Mark BIP 174 as finalAndrew Chow
2021-01-15Include PSBT versions that can or must include fieldAndrew Chow
2021-01-15Specify procedure for new fields and versionsAndrew Chow
2021-01-15Explicitly specify PSBTv0Andrew Chow
2021-01-14Reformat BIP 174Andrew Chow
2021-01-13BIP 174: clarify format of proprietary extensions.Rusty Russell
"Variable length string identifier" is not defined anywhere, and the suggestion to use "0x00" is also deeply unclear. I assumed it meant a nul-terminated string! Be explicit: you mean it must be a compact siz1\e unsigned int length, followed by that many identifier bytes, followed by a compact size unsigned int subtype, followed by optional keydata. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-11-16fixed input test case description as per output test case descriptionFerdinando M. Ametrano
2020-11-15fixed typosfametrano
2020-10-05Merge pull request #981 from apoelstra/2020-08-rename-hash-preimagesLuke Dashjr
BIP174: add `_IN_` to names of new hash preimage fields
2020-10-05Merge pull request #990 from dr-orlovsky/patch-3Luke Dashjr
BIp 174: fixing typo in rationale reference with closed tag
2020-09-08BIp 174: fixing typo in rationale reference with closed tagDr. Maxim Orlovsky
2020-09-07BIP 174: removing extra "fields" wordDr. Maxim Orlovsky
2020-09-07BIP 174: rename responsibilities->roles to match Bitcoin CoreDr. Maxim Orlovsky
[Bitcoin Core uses "roles" instead of "responsibilities"](https://github.com/bitcoin/bitcoin/blob/master/src/psbt.h#L559) and it makes semantical sense (plus less verbose).
2020-09-07Require creator to initialize empty output fieldsDr. Maxim Orlovsky
The current version of the spec requires creator role to initialize empty input fields, but says nothing about output field initialization. At the same time, the following role, updater, "should also add redeemScripts, witnessScripts, and BIP 32 derivation paths to the input and output data if it knows them.", which does not make any sense if the fields were uninitialized. The [current Bitcoin Core implementation does this](https://github.com/bitcoin/bitcoin/blob/a24806c25d7a81a9c436de58eb5778d93abab16b/src/psbt.cpp#L12), and [other PSBT implementations, like rust-bitcoin, follow this practice](https://github.com/rust-bitcoin/rust-bitcoin/blob/master/src/util/psbt/mod.rs#L59)
2020-08-27bip 174: add new hash preimage fields to Appendix AAndrew Poelstra
2020-08-26bip174: add `_IN_` to new hash preimage fieldsAndrew Poelstra
2020-08-20Merge pull request #964 from sanket1729/masterLuke Dashjr
BIP 174: Fix formatting changes
2020-08-20Merge pull request #955 from apoelstra/2020-07-hash-preimages-to-174Luke Dashjr
BIP174: add hash preimage fields to inputs
2020-08-11BIP174: add hash preimage fields to inputsAndrew Poelstra