From e89d2098041d265131915c4e006a51478ff664bb Mon Sep 17 00:00:00 2001
From: Sebastian <sebasjm@gmail.com>
Date: Wed, 6 Mar 2024 11:07:42 -0300
Subject: fix #8564

---
 .../src/components/Checkbox.tsx                    |  1 +
 .../src/hooks/useSettings.ts                       |  8 +--
 .../src/wallet/AddBackupProvider/state.ts          | 71 +++++++++++-----------
 .../src/wallet/AddBackupProvider/test.ts           |  6 ++
 4 files changed, 48 insertions(+), 38 deletions(-)

(limited to 'packages/taler-wallet-webextension')

diff --git a/packages/taler-wallet-webextension/src/components/Checkbox.tsx b/packages/taler-wallet-webextension/src/components/Checkbox.tsx
index 70dfab597..ec1b93a01 100644
--- a/packages/taler-wallet-webextension/src/components/Checkbox.tsx
+++ b/packages/taler-wallet-webextension/src/components/Checkbox.tsx
@@ -31,6 +31,7 @@ export function Checkbox({
   label,
   description,
 }: Props): VNode {
+
   return (
     <div>
       <input
diff --git a/packages/taler-wallet-webextension/src/hooks/useSettings.ts b/packages/taler-wallet-webextension/src/hooks/useSettings.ts
index 8c9d09caf..37d2f13d7 100644
--- a/packages/taler-wallet-webextension/src/hooks/useSettings.ts
+++ b/packages/taler-wallet-webextension/src/hooks/useSettings.ts
@@ -54,11 +54,11 @@ export function useSettings(): [
   Readonly<Settings>,
   <T extends keyof Settings>(key: T, value: Settings[T]) => void,
 ] {
-  const { value, update } = useLocalStorage(SETTINGS_KEY);
+  const { value, update } = useLocalStorage(SETTINGS_KEY, defaultSettings);
 
-  const parsed: Settings = value ?? defaultSettings;
   function updateField<T extends keyof Settings>(k: T, v: Settings[T]) {
-    update({ ...parsed, [k]: v });
+    update({ ...value, [k]: v });
   }
-  return [parsed, updateField];
+  console.log("ASDeeeeASD")
+  return [value, updateField];
 }
diff --git a/packages/taler-wallet-webextension/src/wallet/AddBackupProvider/state.ts b/packages/taler-wallet-webextension/src/wallet/AddBackupProvider/state.ts
index e6d46a626..75b8e53c0 100644
--- a/packages/taler-wallet-webextension/src/wallet/AddBackupProvider/state.ts
+++ b/packages/taler-wallet-webextension/src/wallet/AddBackupProvider/state.ts
@@ -99,42 +99,45 @@ function useUrlState<T>(
   }
   const constHref = href;
 
-  useDebounceEffect(
-    500,
-    constHref == undefined
-      ? undefined
-      : async () => {
-          const req = await fetch(constHref).catch((e) => {
-            return setState({
-              status: "network-error",
-              href: constHref,
-            });
-          });
-          if (!req) return;
+  async function checkURL() {
+    if (!constHref) {
+      return;
+    }
+    const req = await fetch(constHref).catch((e) => {
+      return setState({
+        status: "network-error",
+        href: constHref,
+      });
+    });
+    if (!req) return;
+
+    if (req.status >= 400 && req.status < 500) {
+      setState({
+        status: "client-error",
+        code: req.status,
+      });
+      return;
+    }
+    if (req.status > 500) {
+      setState({
+        status: "server-error",
+        code: req.status,
+      });
+      return;
+    }
 
-          if (req.status >= 400 && req.status < 500) {
-            setState({
-              status: "client-error",
-              code: req.status,
-            });
-            return;
-          }
-          if (req.status > 500) {
-            setState({
-              status: "server-error",
-              code: req.status,
-            });
-            return;
-          }
+    const json = await req.json();
+    try {
+      const result = codec.decode(json);
+      setState({ status: "ok", result });
+    } catch (e: any) {
+      setState({ status: "parsing-error", json });
+    }
+  }
 
-          const json = await req.json();
-          try {
-            const result = codec.decode(json);
-            setState({ status: "ok", result });
-          } catch (e: any) {
-            setState({ status: "parsing-error", json });
-          }
-        },
+  useDebounceEffect(
+    500,
+    constHref == undefined ? undefined : checkURL,
     [host, path],
   );
 
diff --git a/packages/taler-wallet-webextension/src/wallet/AddBackupProvider/test.ts b/packages/taler-wallet-webextension/src/wallet/AddBackupProvider/test.ts
index 598ca9369..66f64d82e 100644
--- a/packages/taler-wallet-webextension/src/wallet/AddBackupProvider/test.ts
+++ b/packages/taler-wallet-webextension/src/wallet/AddBackupProvider/test.ts
@@ -45,6 +45,12 @@ describe("AddBackupProvider states", () => {
           expect(state.name.value).eq("");
           expect(state.url.value).eq("");
         },
+        (state) => {
+          expect(state.status).equal("select-provider");
+          if (state.status !== "select-provider") return;
+          expect(state.name.value).eq("");
+          expect(state.url.value).eq("");
+        },
       ],
       TestingContext,
     );
-- 
cgit v1.2.3