From 7f3253333ebd5ac825901f2f74db690588d3ac96 Mon Sep 17 00:00:00 2001
From: Sebastian <sebasjm@gmail.com>
Date: Tue, 9 Apr 2024 13:21:51 -0300
Subject: fix #8716 and pagination

---
 .../src/paths/instance/orders/list/ListPage.tsx            |  6 ------
 .../src/paths/instance/orders/list/Table.tsx               | 14 ++------------
 .../src/paths/instance/orders/list/index.tsx               |  6 ++----
 3 files changed, 4 insertions(+), 22 deletions(-)

(limited to 'packages/merchant-backoffice-ui/src/paths/instance/orders/list')

diff --git a/packages/merchant-backoffice-ui/src/paths/instance/orders/list/ListPage.tsx b/packages/merchant-backoffice-ui/src/paths/instance/orders/list/ListPage.tsx
index 12762c3b3..408bc0c0a 100644
--- a/packages/merchant-backoffice-ui/src/paths/instance/orders/list/ListPage.tsx
+++ b/packages/merchant-backoffice-ui/src/paths/instance/orders/list/ListPage.tsx
@@ -48,8 +48,6 @@ export interface ListPageProps {
 
   orders: (TalerMerchantApi.OrderHistoryEntry & WithId)[];
   onLoadMoreBefore?: () => void;
-  hasMoreBefore?: boolean;
-  hasMoreAfter?: boolean;
   onLoadMoreAfter?: () => void;
 
   onSelectOrder: (o: TalerMerchantApi.OrderHistoryEntry & WithId) => void;
@@ -58,8 +56,6 @@ export interface ListPageProps {
 }
 
 export function ListPage({
-  hasMoreAfter,
-  hasMoreBefore,
   onLoadMoreAfter,
   onLoadMoreBefore,
   orders,
@@ -218,8 +214,6 @@ export function ListPage({
         onCopyURL={onCopyURL}
         onSelect={onSelectOrder}
         onRefund={onRefundOrder}
-        hasMoreAfter={hasMoreAfter}
-        hasMoreBefore={hasMoreBefore}
         onLoadMoreAfter={onLoadMoreAfter}
         onLoadMoreBefore={onLoadMoreBefore}
       />
diff --git a/packages/merchant-backoffice-ui/src/paths/instance/orders/list/Table.tsx b/packages/merchant-backoffice-ui/src/paths/instance/orders/list/Table.tsx
index 919b608c3..a9314d005 100644
--- a/packages/merchant-backoffice-ui/src/paths/instance/orders/list/Table.tsx
+++ b/packages/merchant-backoffice-ui/src/paths/instance/orders/list/Table.tsx
@@ -50,8 +50,6 @@ interface Props {
   onCreate: () => void;
   onSelect: (order: Entity) => void;
   onLoadMoreBefore?: () => void;
-  hasMoreBefore?: boolean;
-  hasMoreAfter?: boolean;
   onLoadMoreAfter?: () => void;
 }
 
@@ -63,8 +61,6 @@ export function CardTable({
   onSelect,
   onLoadMoreAfter,
   onLoadMoreBefore,
-  hasMoreAfter,
-  hasMoreBefore,
 }: Props): VNode {
   const [rowSelection, rowSelectionHandler] = useState<string[]>([]);
 
@@ -105,8 +101,6 @@ export function CardTable({
                 rowSelectionHandler={rowSelectionHandler}
                 onLoadMoreAfter={onLoadMoreAfter}
                 onLoadMoreBefore={onLoadMoreBefore}
-                hasMoreAfter={hasMoreAfter}
-                hasMoreBefore={hasMoreBefore}
               />
             ) : (
               <EmptyTable />
@@ -125,8 +119,6 @@ interface TableProps {
   onSelect: (id: Entity) => void;
   rowSelectionHandler: StateUpdater<string[]>;
   onLoadMoreBefore?: () => void;
-  hasMoreBefore?: boolean;
-  hasMoreAfter?: boolean;
   onLoadMoreAfter?: () => void;
 }
 
@@ -137,14 +129,12 @@ function Table({
   onCopyURL,
   onLoadMoreAfter,
   onLoadMoreBefore,
-  hasMoreAfter,
-  hasMoreBefore,
 }: TableProps): VNode {
   const { i18n } = useTranslationContext();
   const [settings] = usePreference();
   return (
     <div class="table-container">
-      {hasMoreBefore && (
+      {onLoadMoreBefore && (
         <button class="button is-fullwidth" onClick={onLoadMoreBefore}>
           <i18n.Translate>load first page</i18n.Translate>
         </button>
@@ -218,7 +208,7 @@ function Table({
           })}
         </tbody>
       </table>
-      {hasMoreAfter && (
+      {onLoadMoreAfter && (
         <button class="button is-fullwidth" 
         data-tooltip={i18n.str`load more orders after the last one`}
         onClick={onLoadMoreAfter}>
diff --git a/packages/merchant-backoffice-ui/src/paths/instance/orders/list/index.tsx b/packages/merchant-backoffice-ui/src/paths/instance/orders/list/index.tsx
index 217eb998a..af1ffbcc6 100644
--- a/packages/merchant-backoffice-ui/src/paths/instance/orders/list/index.tsx
+++ b/packages/merchant-backoffice-ui/src/paths/instance/orders/list/index.tsx
@@ -120,10 +120,8 @@ export default function OrderList({ onCreate, onSelect }: Props): VNode {
 
       <ListPage
         orders={result.body.map((o) => ({ ...o, id: o.order_id }))}
-        onLoadMoreBefore={result.loadFirst}
-        hasMoreBefore={!result.isFirstPage}
-        onLoadMoreAfter={result.loadNext}
-        hasMoreAfter={!result.isLastPage}
+        onLoadMoreBefore={result.isFirstPage ? undefined : result.loadFirst}
+        onLoadMoreAfter={result.isLastPage ? undefined : result.loadNext}
         onSelectOrder={(order) => onSelect(order.id)}
         onRefundOrder={(value) => setOrderToBeRefunded(value)}
         isAllActive={isAllActive}
-- 
cgit v1.2.3