From d822035216d9ad33665a2f8274432918ca7d42be Mon Sep 17 00:00:00 2001 From: Marcello Stanisci Date: Wed, 15 Jan 2020 14:34:13 +0100 Subject: Remove preflight checks where redundant. --- src/auditor/taler-auditor.c | 1 + src/exchange/taler-exchange-aggregator.c | 5 +---- src/exchange/taler-exchange-httpd_db.c | 2 -- 3 files changed, 2 insertions(+), 6 deletions(-) (limited to 'src') diff --git a/src/auditor/taler-auditor.c b/src/auditor/taler-auditor.c index 76285d554..d4fb84d16 100644 --- a/src/auditor/taler-auditor.c +++ b/src/auditor/taler-auditor.c @@ -1120,6 +1120,7 @@ handle_reserve_out (void *cls, (void) denom_sig; /* FIXME: checked elsewhere? If so, potential for optimization to simply not fetch this value from DB! */ + /* should be monotonically increasing */ GNUNET_assert (rowid >= ppr.last_reserve_out_serial_id); ppr.last_reserve_out_serial_id = rowid + 1; diff --git a/src/exchange/taler-exchange-aggregator.c b/src/exchange/taler-exchange-aggregator.c index 40577b0cc..fe3ef39cc 100644 --- a/src/exchange/taler-exchange-aggregator.c +++ b/src/exchange/taler-exchange-aggregator.c @@ -1247,8 +1247,7 @@ run_reserve_closures (void *cls) GNUNET_SCHEDULER_shutdown (); return; } - db_plugin->preflight (db_plugin->cls, - session); + if (GNUNET_OK != db_plugin->start (db_plugin->cls, session, @@ -1798,8 +1797,6 @@ run_transfers (void *cls) GNUNET_SCHEDULER_shutdown (); return; } - db_plugin->preflight (db_plugin->cls, - session); if (GNUNET_OK != db_plugin->start (db_plugin->cls, session, diff --git a/src/exchange/taler-exchange-httpd_db.c b/src/exchange/taler-exchange-httpd_db.c index 19781f97f..be7a0300b 100644 --- a/src/exchange/taler-exchange-httpd_db.c +++ b/src/exchange/taler-exchange-httpd_db.c @@ -108,8 +108,6 @@ TEH_DB_run_transaction (struct MHD_Connection *connection, "could not establish database session"); return GNUNET_SYSERR; } - TEH_plugin->preflight (TEH_plugin->cls, - session); for (unsigned int retries = 0; retries < MAX_TRANSACTION_COMMIT_RETRIES; retries++) { -- cgit v1.2.3