From 515ae722f5a1c48e73a3cfb205719ec7443031b6 Mon Sep 17 00:00:00 2001
From: Christian Grothoff <christian@grothoff.org>
Date: Fri, 22 Sep 2023 12:59:32 +0200
Subject: -misc minor fixes

---
 src/testing/testing_api_cmd_age_withdraw.c | 15 +++++++++------
 src/testing/testing_api_cmd_oauth.c        |  9 ++++++---
 src/testing/testing_api_twister_helpers.c  |  4 +++-
 3 files changed, 18 insertions(+), 10 deletions(-)

(limited to 'src/testing')

diff --git a/src/testing/testing_api_cmd_age_withdraw.c b/src/testing/testing_api_cmd_age_withdraw.c
index 98d0e0f2e..30f409f4a 100644
--- a/src/testing/testing_api_cmd_age_withdraw.c
+++ b/src/testing/testing_api_cmd_age_withdraw.c
@@ -585,12 +585,14 @@ age_withdraw_reveal_cb (
       awrs->denom_sigs = GNUNET_new_array (awrs->num_coins,
                                            struct TALER_DenominationSignature);
       for (size_t n = 0; n < awrs->num_coins; n++)
-        TALER_denom_sig_unblind (&awrs->denom_sigs[n],
-                                 &response->details.ok.blinded_denom_sigs[n],
-                                 &aws->coin_outputs[n].details.blinding_key,
-                                 &aws->coin_outputs[n].details.h_coin_pub,
-                                 &aws->coin_outputs[n].details.alg_values,
-                                 &aws->coin_inputs[n].denom_pub->key);
+        GNUNET_assert (GNUNET_OK ==
+                       TALER_denom_sig_unblind (
+                         &awrs->denom_sigs[n],
+                         &response->details.ok.blinded_denom_sigs[n],
+                         &aws->coin_outputs[n].details.blinding_key,
+                         &aws->coin_outputs[n].details.h_coin_pub,
+                         &aws->coin_outputs[n].details.alg_values,
+                         &aws->coin_inputs[n].denom_pub->key));
       GNUNET_log (GNUNET_ERROR_TYPE_INFO,
                   "age-withdraw reveal success!\n");
     }
@@ -640,6 +642,7 @@ age_withdraw_reveal_run (
   {
     GNUNET_break (0);
     TALER_TESTING_interpreter_fail (is);
+    return;
   }
   GNUNET_assert (age_withdraw_cmd->run == age_withdraw_run);
   aws = age_withdraw_cmd->cls;
diff --git a/src/testing/testing_api_cmd_oauth.c b/src/testing/testing_api_cmd_oauth.c
index fcf7e843a..b086d2297 100644
--- a/src/testing/testing_api_cmd_oauth.c
+++ b/src/testing/testing_api_cmd_oauth.c
@@ -193,10 +193,13 @@ handler_cb (void *cls,
                                  "Bob"),
         GNUNET_JSON_pack_string ("last_name",
                                  "Builder"));
+
     if (NULL != oas->birthdate)
-      json_object_set_new (data,
-                           "birthdate",
-                           json_string_nocheck (oas->birthdate));
+      GNUNET_assert (0 ==
+                     json_object_set_new (data,
+                                          "birthdate",
+                                          json_string_nocheck (
+                                            oas->birthdate)));
 
     body = GNUNET_JSON_PACK (
       GNUNET_JSON_pack_string (
diff --git a/src/testing/testing_api_twister_helpers.c b/src/testing/testing_api_twister_helpers.c
index 935d8bcc1..fef631e50 100644
--- a/src/testing/testing_api_twister_helpers.c
+++ b/src/testing/testing_api_twister_helpers.c
@@ -116,7 +116,9 @@ TALER_TWISTER_run_twister (const char *config_filename)
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Could not start the taler-twister client\n");
-    GNUNET_OS_process_kill (proc, SIGTERM);
+    GNUNET_break (0 ==
+                  GNUNET_OS_process_kill (proc,
+                                          SIGTERM));
     GNUNET_OS_process_wait (proc);
     GNUNET_OS_process_destroy (proc);
     TWISTER_FAIL ();
-- 
cgit v1.2.3