From 9ed99558e21ac6b81f112670b982262d2349e5a5 Mon Sep 17 00:00:00 2001
From: Christian Grothoff <christian@grothoff.org>
Date: Mon, 22 Aug 2022 22:45:41 +0200
Subject: -fix clang compiler warnings

---
 src/kyclogic/kyclogic_api.c              |  1 +
 src/kyclogic/plugin_kyclogic_oauth2.c    |  9 +++++++++
 src/kyclogic/plugin_kyclogic_template.c  | 11 +++++++++++
 src/kyclogic/taler-exchange-kyc-tester.c | 12 +++++++++++-
 4 files changed, 32 insertions(+), 1 deletion(-)

(limited to 'src/kyclogic')

diff --git a/src/kyclogic/kyclogic_api.c b/src/kyclogic/kyclogic_api.c
index 5081e09d5..3170ba99c 100644
--- a/src/kyclogic/kyclogic_api.c
+++ b/src/kyclogic/kyclogic_api.c
@@ -1183,6 +1183,7 @@ TALER_KYCLOGIC_requirements_to_logic (const char *requirements,
   unsigned int max_checks = 0;
   const struct TALER_KYCLOGIC_KycProvider *kp_best = NULL;
 
+  // FIXME: use 'ut' to filter providers!
   if (NULL == requirements)
     return GNUNET_NO;
   {
diff --git a/src/kyclogic/plugin_kyclogic_oauth2.c b/src/kyclogic/plugin_kyclogic_oauth2.c
index b8f2d70fd..91c936bbc 100644
--- a/src/kyclogic/plugin_kyclogic_oauth2.c
+++ b/src/kyclogic/plugin_kyclogic_oauth2.c
@@ -520,6 +520,7 @@ oauth2_initiate (void *cls,
 {
   struct TALER_KYCLOGIC_InitiateHandle *ih;
 
+  (void) cls;
   ih = GNUNET_new (struct TALER_KYCLOGIC_InitiateHandle);
   ih->legitimization_uuid = legitimization_uuid;
   ih->cb = cb;
@@ -943,6 +944,7 @@ oauth2_proof (void *cls,
   struct TALER_KYCLOGIC_ProofHandle *ph;
   const char *code;
 
+  (void) url_path;
   GNUNET_break (NULL == provider_user_id);
   ph = GNUNET_new (struct TALER_KYCLOGIC_ProofHandle);
   GNUNET_snprintf (ph->provider_legitimization_id,
@@ -1153,6 +1155,13 @@ oauth2_webhook (void *cls,
   struct PluginState *ps = cls;
   struct TALER_KYCLOGIC_WebhookHandle *wh;
 
+  (void) pd;
+  (void) plc;
+  (void) plc_cls;
+  (void) http_method;
+  (void) url_path;
+  (void) connection;
+  (void) body;
   wh = GNUNET_new (struct TALER_KYCLOGIC_WebhookHandle);
   wh->cb = cb;
   wh->cb_cls = cb_cls;
diff --git a/src/kyclogic/plugin_kyclogic_template.c b/src/kyclogic/plugin_kyclogic_template.c
index 190c3321e..b4531117e 100644
--- a/src/kyclogic/plugin_kyclogic_template.c
+++ b/src/kyclogic/plugin_kyclogic_template.c
@@ -249,6 +249,7 @@ template_initiate (void *cls,
 {
   struct TALER_KYCLOGIC_InitiateHandle *ih;
 
+  (void) cls;
   ih = GNUNET_new (struct TALER_KYCLOGIC_InitiateHandle);
   ih->legitimization_uuid = legitimization_uuid;
   ih->cb = cb;
@@ -303,6 +304,11 @@ template_proof (void *cls,
   struct PluginState *ps = cls;
   struct TALER_KYCLOGIC_ProofHandle *ph;
 
+  (void) url_path;
+  (void) account_id;
+  (void) process_row;
+  (void) provider_user_id;
+  (void) provider_legitimization_id;
   ph = GNUNET_new (struct TALER_KYCLOGIC_ProofHandle);
   ph->ps = ps;
   ph->pd = pd;
@@ -358,6 +364,11 @@ template_webhook (void *cls,
   struct PluginState *ps = cls;
   struct TALER_KYCLOGIC_WebhookHandle *wh;
 
+  (void) plc;
+  (void) plc_cls;
+  (void) http_method;
+  (void) url_path;
+  (void) body;
   wh = GNUNET_new (struct TALER_KYCLOGIC_WebhookHandle);
   wh->cb = cb;
   wh->cb_cls = cb_cls;
diff --git a/src/kyclogic/taler-exchange-kyc-tester.c b/src/kyclogic/taler-exchange-kyc-tester.c
index 306493e2c..64b140877 100644
--- a/src/kyclogic/taler-exchange-kyc-tester.c
+++ b/src/kyclogic/taler-exchange-kyc-tester.c
@@ -454,8 +454,15 @@ webhook_finished_cb (
 {
   struct KycWebhookContext *kwh = cls;
 
+  (void) expiration;
+  (void) provider_section;
   kwh->wh = NULL;
-  // FIXME: check arguments for validity?
+  GNUNET_break (0 == GNUNET_memcmp (account_id,
+                                    &cmd_line_h_payto));
+  GNUNET_break (0 == strcmp (provider_user_id,
+                             cmd_provider_user_id));
+  GNUNET_break (0 == strcmp (provider_legitimization_id,
+                             cmd_provider_legitimization_id));
   switch (status)
   {
   case TALER_KYCLOGIC_STATUS_SUCCESS:
@@ -524,6 +531,7 @@ kyc_provider_account_lookup (
   struct TALER_PaytoHashP *h_payto,
   uint64_t *legi_row)
 {
+  (void) cls;
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
               "Simulated account lookup using `%s/%s'\n",
               provider_section,
@@ -695,6 +703,7 @@ proof_cb (
 {
   struct ProofRequestState *rs = cls;
 
+  (void) expiration;
   GNUNET_log (GNUNET_ERROR_TYPE_MESSAGE,
               "KYC legitimization %s completed with status %d (%u) for %s\n",
               provider_legitimization_id,
@@ -1305,6 +1314,7 @@ initiate_cb (
   const char *provider_legitimization_id,
   const char *error_msg_hint)
 {
+  (void) cls;
   ih = NULL;
   if (TALER_EC_NONE != ec)
   {
-- 
cgit v1.2.3