From 9294f3663712dbc60da1dc575278b47e9e56c6fa Mon Sep 17 00:00:00 2001 From: Christian Grothoff Date: Tue, 17 Oct 2023 10:52:06 +0200 Subject: -remove dead index, add comment on live index --- src/exchangedb/0002-reserves_in.sql | 16 ++++++---------- .../pg_select_reserves_in_above_serial_id_by_account.c | 7 +++++-- 2 files changed, 11 insertions(+), 12 deletions(-) (limited to 'src/exchangedb') diff --git a/src/exchangedb/0002-reserves_in.sql b/src/exchangedb/0002-reserves_in.sql index 1dfc5db69..197a815b3 100644 --- a/src/exchangedb/0002-reserves_in.sql +++ b/src/exchangedb/0002-reserves_in.sql @@ -83,22 +83,18 @@ BEGIN 'ON ' || table_name || ' ' '(reserve_in_serial_id);' ); - -- FIXME: where do we need this index? Can we do better? - EXECUTE FORMAT ( - 'CREATE INDEX ' || table_name || '_by_exch_accnt_section_execution_date_idx ' - 'ON ' || table_name || ' ' - '(exchange_account_section ' - ',execution_date' - ');' - ); - -- FIXME: where do we need this index? Can we do better? EXECUTE FORMAT ( 'CREATE INDEX ' || table_name || '_by_exch_accnt_reserve_in_serial_id_idx ' 'ON ' || table_name || ' ' '(exchange_account_section' - ',reserve_in_serial_id DESC' + ',reserve_in_serial_id ASC' ');' ); + EXECUTE FORMAT ( + 'COMMENT ON INDEX ' || table_name || '_by_exch_accnt_reserve_in_serial_id_idx ' + 'IS ' || quote_literal ('for pg_select_reserves_in_above_serial_id_by_account') || ';' + ); + END $$; diff --git a/src/exchangedb/pg_select_reserves_in_above_serial_id_by_account.c b/src/exchangedb/pg_select_reserves_in_above_serial_id_by_account.c index daedb3f8b..1c7bc15a0 100644 --- a/src/exchangedb/pg_select_reserves_in_above_serial_id_by_account.c +++ b/src/exchangedb/pg_select_reserves_in_above_serial_id_by_account.c @@ -24,6 +24,8 @@ #include "taler_pq_lib.h" #include "pg_select_reserves_in_above_serial_id_by_account.h" #include "pg_helper.h" + + /** * Closure for #reserves_in_serial_helper_cb(). */ @@ -152,8 +154,9 @@ TEH_PG_select_reserves_in_above_serial_id_by_account ( " USING (reserve_pub)" " JOIN wire_targets" " ON (wire_source_h_payto = wire_target_h_payto)" - " WHERE reserve_in_serial_id>=$1 AND exchange_account_section=$2" - " ORDER BY reserve_in_serial_id;"); + " WHERE reserve_in_serial_id>=$1" + " AND exchange_account_section=$2" + " ORDER BY reserve_in_serial_id ASC;"); qs = GNUNET_PQ_eval_prepared_multi_select (pg->conn, "audit_reserves_in_get_transactions_incr_by_account", params, -- cgit v1.2.3