From e2a07a56718b7ad6d5adfcbd391e66be0f5d4e53 Mon Sep 17 00:00:00 2001 From: Jacob Pipkin Date: Fri, 16 Nov 2012 22:34:02 -0600 Subject: dont stuff get_sbo_location into $test, but wrap the if around it directly --- sboremove | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/sboremove b/sboremove index 7ffaf3d..5439524 100755 --- a/sboremove +++ b/sboremove @@ -39,10 +39,10 @@ EOF my ($help, $vers, $non_int, $no_reqs, $alwaysask, @excluded); GetOptions ( - 'help|h' => \$help, - 'version|v' => \$vers, + 'help|h' => \$help, + 'version|v' => \$vers, 'norequirements|R' => \$no_reqs, - 'nointeractive' => \$non_int, + 'nointeractive' => \$non_int, 'alwaysask|a' => \$alwaysask, ); @@ -55,8 +55,7 @@ my $inst_names = get_inst_names $installed; my @remove; for my $sbo (@ARGV) { - my $test = get_sbo_location ($sbo); - if ( defined $test ) { + if (get_sbo_location ($sbo)) { if ($sbo ~~ @$inst_names) { push @remove, $sbo } else { -- cgit v1.2.3