From bb9f8dd0e15a9744b8d09d06ecb6a18ca3dcc173 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Tue, 6 Sep 2016 15:26:37 +0100 Subject: qcow2: fix encryption during cow of sectors Broken in previous commit: commit aaa4d20b4972bb1a811ce929502e6741835d584e Author: Kevin Wolf Date: Wed Jun 1 15:21:05 2016 +0200 qcow2: Make copy_sectors() byte based The copy_sectors() code was originally using the 'sector' parameter for encryption, which was passed in by the caller from the QCowL2Meta.offset field (aka the guest logical offset). After the change, the code is using 'cluster_offset' which was passed in from QCow2L2Meta.alloc_offset field (aka the host physical offset). This would cause the data to be encrypted using an incorrect initialization vector which will in turn cause later reads to return garbage. Although current qcow2 built-in encryption is blocked from usage in the emulator, one could still hit this if writing to the file via qemu-{img,io,nbd} commands. Cc: qemu-stable@nongnu.org Signed-off-by: Daniel P. Berrange Signed-off-by: Kevin Wolf --- tests/qemu-iotests/group | 1 + 1 file changed, 1 insertion(+) (limited to 'tests/qemu-iotests/group') diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index a57fc9218f..7eb17707a2 100644 --- a/tests/qemu-iotests/group +++ b/tests/qemu-iotests/group @@ -157,6 +157,7 @@ 155 rw auto 156 rw auto quick 157 auto +158 rw auto quick 159 rw auto quick 160 rw auto quick 162 auto quick -- cgit v1.2.3