From 9a2fd4347c40321f5cbb4ab4220e759fcbf87d03 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Mon, 13 Apr 2015 14:01:39 +0100 Subject: crypto: add sanity checking of TLS x509 credentials If the administrator incorrectly sets up their x509 certificates, the errors seen at runtime during connection attempts are very obscure and difficult to diagnose. This has been a particular problem for people using openssl to generate their certificates instead of the gnutls certtool, because the openssl tools don't turn on the various x509 extensions that gnutls expects to be present by default. This change thus adds support in the TLS credentials object to sanity check the certificates when QEMU first loads them. This gives the administrator immediate feedback for the majority of common configuration mistakes, reducing the pain involved in setting up TLS. The code is derived from equivalent code that has been part of libvirt's TLS support and has been seen to be valuable in assisting admins. It is possible to disable the sanity checking, however, via the new 'sanity-check' property on the tls-creds object type, with a value of 'no'. Unit tests are included in this change to verify the correctness of the sanity checking code in all the key scenarios it is intended to cope with. As part of the test suite, the pkix_asn1_tab.c from gnutls is imported. This file is intentionally copied from the (long since obsolete) gnutls 1.6.3 source tree, since that version was still under GPLv2+, rather than the GPLv3+ of gnutls >= 2.0. Signed-off-by: Daniel P. Berrange --- tests/.gitignore | 3 +++ 1 file changed, 3 insertions(+) (limited to 'tests/.gitignore') diff --git a/tests/.gitignore b/tests/.gitignore index ccc92e4761..7b4ee238b7 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -12,6 +12,9 @@ test-bitops test-coroutine test-crypto-cipher test-crypto-hash +test-crypto-tlscredsx509 +test-crypto-tlscredsx509-work/ +test-crypto-tlscredsx509-certs/ test-cutils test-hbitmap test-int128 -- cgit v1.2.3