From 5e9b473a3d7fbb915df4b3f5487e5056762087f8 Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Wed, 13 Mar 2013 10:41:31 +0100 Subject: spice-qemu-char: Fix name parameter issues after qapi-ifying The strings passed in through the qapi calls are dynamic memory, since we want to have them stick around longer then just the call to qemu_chr_open_spice_* we need to strdup them. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- spice-qemu-char.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'spice-qemu-char.c') diff --git a/spice-qemu-char.c b/spice-qemu-char.c index 0c92ca850b..a94f76ba2a 100644 --- a/spice-qemu-char.c +++ b/spice-qemu-char.c @@ -185,6 +185,11 @@ static void spice_chr_close(struct CharDriverState *chr) printf("%s\n", __func__); vmc_unregister_interface(s); QLIST_REMOVE(s, next); + + g_free((char *)s->sin.subtype); +#if SPICE_SERVER_VERSION >= 0x000c02 + g_free((char *)s->sin.portname); +#endif g_free(s); } @@ -226,7 +231,7 @@ static CharDriverState *chr_open(const char *subtype) s = g_malloc0(sizeof(SpiceCharDriver)); s->chr = chr; s->active = false; - s->sin.subtype = subtype; + s->sin.subtype = g_strdup(subtype); chr->opaque = s; chr->chr_write = spice_chr_write; chr->chr_close = spice_chr_close; @@ -284,7 +289,7 @@ CharDriverState *qemu_chr_open_spice_port(const char *name) chr = chr_open("port"); s = chr->opaque; - s->sin.portname = name; + s->sin.portname = g_strdup(name); return chr; } -- cgit v1.2.3