From 0794d8895ef8d1bd6db528e5d9ca19b86297803b Mon Sep 17 00:00:00 2001 From: Amit Shah Date: Fri, 17 Jun 2016 17:46:39 +0530 Subject: vmstate-static-checker: fix size mismatch detection in unused fields If a field changed from something to unused, the checker wasn't flagging if the field size mismatched. This was noticed in: http://thread.gmane.org/gmane.comp.emulators.qemu/419802 where the 4->1 size change along with field name change to 'unused' wasn't being flagged. Fix this. Signed-off-by: Amit Shah Message-Id: Signed-off-by: Amit Shah --- scripts/vmstate-static-checker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'scripts') diff --git a/scripts/vmstate-static-checker.py b/scripts/vmstate-static-checker.py index b5ecaf644d..14a27e7f6a 100755 --- a/scripts/vmstate-static-checker.py +++ b/scripts/vmstate-static-checker.py @@ -185,7 +185,7 @@ def check_fields(src_fields, dest_fields, desc, sec): if unused_count == 0: advance_dest = True - if unused_count > 0: + if unused_count != 0: if advance_dest == False: unused_count = unused_count - s_item["size"] if unused_count == 0: -- cgit v1.2.3