From ae50b2747f77944faa79eb914272b54eb30b63b3 Mon Sep 17 00:00:00 2001 From: Mark McLoughlin Date: Wed, 1 Jul 2009 16:46:38 +0100 Subject: Don't leak VLANClientState on PCI hot remove destroy_nic() requires that NICInfo::private by a PCIDevice pointer, but then goes on to require that the same pointer matches VLANClientState::opaque. That is no longer the case for virtio-net since qdev and wasn't previously the case for rtl8139, ne2k_pci or eepro100. Make the situation a lot more clear by maintaining a VLANClientState pointer in NICInfo. Signed-off-by: Mark McLoughlin Signed-off-by: Anthony Liguori --- net.h | 1 + 1 file changed, 1 insertion(+) (limited to 'net.h') diff --git a/net.h b/net.h index 64d5e22f16..6026e10361 100644 --- a/net.h +++ b/net.h @@ -96,6 +96,7 @@ struct NICInfo { const char *name; const char *devaddr; VLANState *vlan; + VLANClientState *vc; void *private; int used; int bootable; -- cgit v1.2.3