From 8e84865e54cb66fd7b57bb18c312ad3d56b6e276 Mon Sep 17 00:00:00 2001 From: Amit Shah Date: Tue, 27 Jul 2010 15:49:19 +0530 Subject: migration: Accept 'cont' only after successful incoming migration When a 'cont' is issued on a VM that's just waiting for an incoming migration, the VM reboots and boots into the guest, possibly corrupting its storage since it could be shared with another VM running elsewhere. Ensure that a VM started with '-incoming' is only run when an incoming migration successfully completes. A new qerror, QERR_MIGRATION_EXPECTED, is added to signal that 'cont' failed due to no incoming migration has been attempted yet. Reported-by: Laine Stump Signed-off-by: Amit Shah Reviewed-by: Luiz Capitulino Signed-off-by: Aurelien Jarno --- monitor.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'monitor.c') diff --git a/monitor.c b/monitor.c index 45fd48291a..5366c36525 100644 --- a/monitor.c +++ b/monitor.c @@ -1056,6 +1056,10 @@ static int do_cont(Monitor *mon, const QDict *qdict, QObject **ret_data) { struct bdrv_iterate_context context = { mon, 0 }; + if (incoming_expected) { + qerror_report(QERR_MIGRATION_EXPECTED); + return -1; + } bdrv_iterate(encrypted_bdrv_it, &context); /* only resume the vm if all keys are set and valid */ if (!context.err) { -- cgit v1.2.3